From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D98833A6B77 for ; Tue, 31 Mar 2026 10:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774951834; cv=none; b=a2dC/Ti1ffwxMcmvcdGb+t23gTbLLMYKlv39O0/cdFyyv6uOwH+MsSDWCarrxojiHgXbVVDhRnQslRTTN0udqz5OuOIoDEO3x+OPaD/bSMG/nx3kuHFbA1K/tsJ8BRiNwI2hETnpVUGPy3qwvBk/TiVtDK132llE4JNSqdlSgQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774951834; c=relaxed/simple; bh=6xORAGlWnQ4RaG76LpJ7Jd0JYS05i5nw4QKy2voh05g=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=kVaInlMGZnW9gjBjrNeioo0dsj2hPxu2n8GbtkLzJtIq/3xpy/8WFVhfuMpqJ+tD3cuM3oT83eiXZ+VVM6qE4rCR24bUcfT6k87FXO+bs47rVAkcp9JSmy0NIItj33346kAOEA1c3LoPbOFvMBeSUY2j4Ri7W9JdmBPMdQGumf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pvG+2Bob; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M+pbuP3F; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pvG+2Bob"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M+pbuP3F" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V7qFb4431287 for ; Tue, 31 Mar 2026 10:10:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OscVYcVLSC1PAO5AyKwi55H3UQZzDc7xDB2rFKH+jPA=; b=pvG+2BobqzBs0TOi aYw1IjEyVY0cM3/yP62t3d/lGzz5EFXojW6zGq/5YmszC80MMcWoOUSioxfD5dHt Q+ELIZEJhW++jEtY/uK7d9HYYVwmtKGvbSjiEu5WDLUuiZIRVWkbHYB7PYbNHdQf vhnai5uso2JMOmOV1vm/Zb8sh3QbMS+pInOdztpj34dH5Sg+wf6tLfIAsvGvCxke vu+2+142yDkoRA4cbkid3zrA9QhRz+z3ccrzDBf7/lC/j+0FgWWFUVqr9sPIPnxj aPFTruBp61q6y29mj1/qObXpWUMx1kYpEX9HFfcXVa2dj3cL4b/NtB8Bk78JopGX /w2wNg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d84bfhwdw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 10:10:31 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8d1a5661ff1so58450985a.0 for ; Tue, 31 Mar 2026 03:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774951831; x=1775556631; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=OscVYcVLSC1PAO5AyKwi55H3UQZzDc7xDB2rFKH+jPA=; b=M+pbuP3FbTUDGk3NVqj1v/nzTE3qN3v8n+MjWTBGGWklA754nKMAAstN+I6dSEFq3j LVi3HVvqrzZB8rzsE5IFepcFYOkaJoteAkdIb0EJNgQJkYJbEsLL0GltUZFrwiBOtE0U F76IBmUIE6M1NMVfBhGV6OnOPf6XD72TXLFwx44VcQkssR5m+G0I/ISvcIxB64pAEnzA 8/Q3uAH6HL37pzSQKfL4o+1vf7tAWoKo68D+7tSkoAin0FOiU9QXYqb9NQahbAQx4mO0 ORrDB0VpJL3BeckjdoSZDA0tO4ENSo5ul22iR+Z+n8j4EajEGMbWxEAeWDbXLCga19hI rykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774951831; x=1775556631; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OscVYcVLSC1PAO5AyKwi55H3UQZzDc7xDB2rFKH+jPA=; b=rIiCp1XvLCxMgVLZyjcN4bBTCrJsbyh/gzdO+BvCXzWqzOvaySWGMY6hn4n5LHhq3B uiQ6MBbcNCaq/f46t6pHSROpYzG6ETUYw4i8f7Q1CyAaN/VmmCgOxLUKILtY4T5r1eWI cHblbuzqowA+tMF+Fgwp0zaKWfz7fAnJzV0Py+6IU/SujwVGoFv0EAxKn+s5TFsjSSzn yn6ffurQjrs640+KlwZ/LcmWIN1/sHGDnaeEkQ1R0dQODhE2gOmvyuTh4W1kOuZaSfSY FiKu07fp/XfBFu6JObLmEd+nWOOmONjSnMXPA10R6UJCggv2PFZWSNZXpuaPlTr+zPIt D1eg== X-Forwarded-Encrypted: i=1; AJvYcCVFJq32qSbdY4vVdxUhx2/VF9Rec0vjVKkuBst/PKmnwhh5fnjUBBP28GkAVJdlbo/j48ArTofOeFO3AEg=@vger.kernel.org X-Gm-Message-State: AOJu0YzUe7AO/Ye41vt5mNlAHL/TtQrMCC6gfL9VM1c8OXA1/eikS6Cg UvUZOPbhBjPhBsCz1L6b10iLCQan0nIZHOg96+PJgFxTgwAU9gSBVHaP2KzB8LUuFtYjvJu98eU RSA3NmCzQLjtsWmkYYNbCYHACfLw9ZalFXoCYtJ1ngO4j30wFPxFdxS6qnCozmZpXC2k= X-Gm-Gg: ATEYQzxBDzXGfawG0XQH7SYv3NwM5bM+ny/++liBVZ8rVVa0Ld5JWFG9tvUHvGsL/IJ Ee4ZTXeZei8yDYqJro0aFeAISgX9/0EaiG/9KEXGPQ6iHFmln4u4vekcumxJPu78pBCUkHw7Tc4 iiZTQbXgUy8jtsSwhU3E+KJ9F4vil+GddnM0ikvEY/z2zaUvEnisjdU0KAPI5wVYHx4WSF3FiQr 7ATKUv46ALz/Z1qlA7RSeNmQW/pr3WCUnZy0+CjIaLHNGD2HV4w5gKu9aNRJmh78am8m1IIhd6r 04QnwnCD6ZRpmZKG5mgW3XeSmSzWaQeAkcW4a1b5IrS0yWMX4fVMg1XRfd83oAAAPSKKKhYgca8 XMNArebOQTElbO1pXLYm5n1hLwyKUYzRvKm6+F5Gr7MvBt4fiX7qu0qJiDXrNyLDVW/EfEYsHfc c0GBw= X-Received: by 2002:a05:620a:4049:b0:8cf:c757:f1d1 with SMTP id af79cd13be357-8d01c82312cmr1476138585a.8.1774951831229; Tue, 31 Mar 2026 03:10:31 -0700 (PDT) X-Received: by 2002:a05:620a:4049:b0:8cf:c757:f1d1 with SMTP id af79cd13be357-8d01c82312cmr1476134685a.8.1774951830813; Tue, 31 Mar 2026 03:10:30 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66b7276304fsm3447998a12.2.2026.03.31.03.10.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:10:29 -0700 (PDT) Message-ID: <51a05279-1759-4c03-8bba-835a9e972ccb@oss.qualcomm.com> Date: Tue, 31 Mar 2026 12:10:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] clk: qcom: Constify qcom_cc_driver_data To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Maxime Coquelin , Alexandre Torgue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20260331091721.61613-3-krzysztof.kozlowski@oss.qualcomm.com> <6ca492d7-c041-42b0-8f41-cd29ab7b4bab@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6ca492d7-c041-42b0-8f41-cd29ab7b4bab@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=INwPywvG c=1 sm=1 tr=0 ts=69cb9d97 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=fArkNfqvCtmK_1YDpdcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA5NyBTYWx0ZWRfX/H62ChZRa30/ XCLG3oCt7bf1Z975kAFflB+YO1DvUpJNMnd5WISojGgeDEyWrsQZLbgFqnd3NiNwihiDH42SNng dRMttIz8OBhf3ynKjsxrXMlyNC1yB1i+7YrClYhxFPzSov3n6+wpNPH1ZIrQ8yEb6AwdZONh1px rn6ouwFNeBjckxQic75yReedwf/eKBFfN1o4ZWGtj23+dRooM+U5rRWEBeZ3ZlSVmg/aMs0Gk/r quIWMltvLtXKP1cGT69z7PxqH3/fhOAZ/00koRzWSkLhuToQsEsUoF+h/cpo/zLwxX/QVtbPZY2 AmsN1RxWtOMLqsyJa/AO0gOFwo0ZMqZrFYLXGzhAQyjWriCCzZ4TjNZCo8hL6fWBd8pT9IzjfER fJGwq80qTrgF0O50FpWs/+X+rcmUNRq56i4ZA6/SRBaGfmxlzL80R9bOzpffFIuw1JZgnuu/jt+ D9k0xC9d+j11MNOmSZA== X-Proofpoint-GUID: rpy5wRKlGKolXxnoiHKbGeKvF8agx0ND X-Proofpoint-ORIG-GUID: rpy5wRKlGKolXxnoiHKbGeKvF8agx0ND X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310097 On 3/31/26 12:09 PM, Krzysztof Kozlowski wrote: > On 31/03/2026 11:33, Konrad Dybcio wrote: >> On 3/31/26 11:17 AM, Krzysztof Kozlowski wrote: >>> The static 'struct qcom_cc_driver_data' contains probe match-like data >>> and is not modified: neither by the driver defining it nor by common.c >>> code using it. >>> >>> Make it const for code safety and code readability. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >> >> [...] >> >>> --- a/drivers/clk/qcom/common.h >>> +++ b/drivers/clk/qcom/common.h >>> @@ -49,7 +49,7 @@ struct qcom_cc_desc { >>> size_t num_icc_hws; >>> unsigned int icc_first_node_id; >>> bool use_rpm; >>> - struct qcom_cc_driver_data *driver_data; >>> + const struct qcom_cc_driver_data *driver_data; >> >> This can be a const ptr to const data, even > > None of other elements in 'qcom_cc_desc' is const pointer, even though > they also could. If doing this change, let's make it consistent - so > shall all of them be const? I thought about it, but then it turns out that videocc-sm8550.c has: video_cc_sm8550_driver_data.clk_cbcrs = video_cc_sm8650_critical_cbcrs So we'd have to duplicate the entire struct Konrad