From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbdETLjv (ORCPT ); Sat, 20 May 2017 07:39:51 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:51734 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdETLjt (ORCPT ); Sat, 20 May 2017 07:39:49 -0400 X-Spam-Flag: NO X-Spam-Score: -0.044 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 385B3261E7D Subject: Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code To: Lyude , amd-gfx@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20170516211202.20325-1-lyude@redhat.com> <20170519234840.5644-1-lyude@redhat.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <51a14f4e-8771-3bca-b05f-25732da50b34@vodafone.de> Date: Sat, 20 May 2017 13:39:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170519234840.5644-1-lyude@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 20.05.2017 um 01:48 schrieb Lyude: > This is the first part of me going through and cleaning up the IRQ handling > code for radeon, since after taking a look at it the other day while trying to > debug something I realized basically all of the code was copy pasted > everywhere, and quite difficult to actually read through. > > Will come up with something for r600 and cik once I've got the chipsets on hand > to test with. > > Lyude (3): > drm/radeon: Cleanup display interrupt handling for evergreen, si > drm/radeon: Cleanup HDMI audio interrupt handling for evergreen > drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si I don't have time to do a line by line review, but what I saw looked very good to me. So the whole seres is Acked-by: Christian König . BTW: You don't want to take a look at the other hw generations as well? Regards, Christian. > > drivers/gpu/drm/radeon/evergreen.c | 943 ++++++-------------------------- > drivers/gpu/drm/radeon/radeon.h | 27 +- > drivers/gpu/drm/radeon/radeon_irq_kms.c | 35 ++ > drivers/gpu/drm/radeon/si.c | 655 +++++----------------- > 4 files changed, 344 insertions(+), 1316 deletions(-) >