From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 50C66C32772
	for <linux-kernel@archiver.kernel.org>; Mon, 22 Aug 2022 16:44:07 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S237117AbiHVQoF (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 22 Aug 2022 12:44:05 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35422 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235301AbiHVQoC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Aug 2022 12:44:02 -0400
Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19938DFA1;
        Mon, 22 Aug 2022 09:44:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding:
        Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender
        :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:
        Resent-Cc:Resent-Message-ID; bh=j9Na8GEDYI1jwE1gHFPogSMPuaiDlQuLvcxA/kW9fo4=;
        t=1661186641; x=1662396241; b=sMjn+x41pQ2gpWT8jOte2h/Ec8KA1irN3ONg9Tfp35S9irH
        rBbkz9lpjdkDg+YRgBTjf7zUhbr+NZZxLEP8hdGF0/AeGRglZkT9g0tmndtcOcw6aTlihlPzT4wVR
        uhvDAAY+R14UshsLx7COJsM3VIXIAj+qDqnPwfG7ncSwJl2GX27Vs2CbnuTax/B0dRfjqC4JcO/sl
        ZPb8dq6aMUu2SHV6t7zil6bMxZDW1avIEr6RMzjgy1c9EUpFJ0B13NbaNA95Z/0lBcH4Uo3MAytXc
        iZiqrk+4m/FkwIZCM34JfjvoRevkQ6wgWiDFi+zIx6MBFk/rnnKVrp65tqrtOe9g==;
Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
        (Exim 4.96)
        (envelope-from <johannes@sipsolutions.net>)
        id 1oQAWm-00Eb6N-34;
        Mon, 22 Aug 2022 18:43:53 +0200
Message-ID: <51a1b56a4d9ed825cb47cf364c5bd72f3338a1a6.camel@sipsolutions.net>
Subject: Re: Aw: Re: help for driver porting - missing member preset_chandef
 in struct wireless_dev
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Frank Wunderlich <frank-w@public-files.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Date:   Mon, 22 Aug 2022 18:43:51 +0200
In-Reply-To: <trinity-64c5eed8-8b6b-4b33-9204-89aff4fce7db-1661186571606@3c-app-gmx-bap06>
References: <trinity-de687d18-b2a2-4cde-9383-a4d6ddba6a77-1661177057496@3c-app-gmx-bap06>
         <b081ef6eb978070740f31f48a1f4be1807f51168.camel@sipsolutions.net>
         <trinity-64c5eed8-8b6b-4b33-9204-89aff4fce7db-1661186571606@3c-app-gmx-bap06>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
X-malware-bazaar: not-scanned
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 22. August 2022 um 17:02 Uhr
> > Von: "Johannes Berg" <johannes@sipsolutions.net>
>=20
> > Yes. Make sure the driver doesn't access it, it should get stuff
> > through
> > other APIs.
>=20
> thanks for response, commented out the use of the member and the wdev
> assignment as it was then unused
> can you tell me which api-call this should be?
> i just want to make sure this is really done as i up-ported the driver
> from 4.9, so if the api-call was introduced later it is maybe missing.

No sorry, I don't know how the driver was/is using it, so I can't tell
you how to replace it.

johannes