From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59892343887 for ; Thu, 28 May 2026 00:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779926758; cv=none; b=hu3yGiVVoRsGCzR5sAAQ3ZWO2PYIPV5pfxchXabXk3ZPTXtKTEHOBcHTx1N74aA5cF5y6oCxQRdGs7NiI2a6kT4QgDilgdY8zN5nZgjj1jsTsc5lH++GAacLmiP7FPXuOKbKQJL3q60s3BRb2tzpESt5P//ry9DP/EP6xDgkBfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779926758; c=relaxed/simple; bh=wVzeBI5iq5pcaL7sKL878hNf9vStv3AgI8KZKMV3sE0=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=SXERXoJbCzISQOTJmMs1tuFOMK6mcvUSKt0F4z+8kbHVHT2czSVre+TkTVevH0amoeLSLHBCfwmuRFIb0KIzkS5F/JoAFhF5d/ib7iD7E7rby91mv9bdcxAETZVAIrvBeXDemcMfI5nYmDr+deC8O/krxSWw7Iyxkr0pHATwb0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=ffz/ENBz; arc=none smtp.client-ip=209.85.160.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="ffz/ENBz" Received: by mail-qt1-f194.google.com with SMTP id d75a77b69052e-50e614fdb42so95353891cf.3 for ; Wed, 27 May 2026 17:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1779926754; x=1780531554; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=Isx2qxK8pV4e9JSva6BI15c8Rdmr8Eimwb3dscRj6BM=; b=ffz/ENBzx4/0fSEWNsMHuHEA+8Z9hlYcuAVwI8g8xSsPHTbo47F9W24oOZQLXGarDd 69LDgHUnyXA9oxGC+cInpQIWh3RVuOF7mp6yf/nMq9qN2SHGV0ns/boLjgm7FNT7KwDH qBI3tgB5WlYZWAakzEv/XPlxG4DIqMhKXnHG2MniOLAIGOls95fKrFOqLlZ1Ge/D9irs 4QqLEVkiL+Gdj2gKaG87C8rwK87/vW7Ni5i3OuPnQcJ2DEuD9YAXxk0qzydiSjf/SWI0 CND25dBsxfkJkxPFjESOPuf2n2srTBrXx2nhVcMsQC8bo60Q0QTvzuohd0ifubE4MFjx wNHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779926754; x=1780531554; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Isx2qxK8pV4e9JSva6BI15c8Rdmr8Eimwb3dscRj6BM=; b=HCXmNzV69j5PC76qSJDA+NFHriTIP8KvCIOagYwCOu2XVvwtM72fhhj4OjsPJmquaQ 1jpKBheTzWWs1+ghaTRabf7wPjSMqeYUxYEpktYM4aJeW0Ph3+EhZymArgu+6c0pDKbX abKCoGmDBRwgaLju5qwcHDQp/08V12ITiFe/3jbrYSDXYkYSJbKVFuCiW0pXIKKQn4oy uNW6k3cqBgExQ2W1EUg5zshHcQf66MwN0VTy2J81cvNRJm/QyeQH/e4SbSTfqeTdDXyY AlCctyW99rVMTq0D0+6wE3TBkgNFw+/g8lUiloM7gLvI7Qfar/SKOpeNBFBx2bHf1PGo PBgQ== X-Forwarded-Encrypted: i=1; AFNElJ/q8cjc6oWTB1YnkvYUqw35LuQzsAUVZF+whMQYO//P2cDZyziYOV8MBoH0TFY3h49DfG5A6cTrzyMKyOA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6FaxxwRY07lyQoWrfUfBVBTRUMKXCWr7A7yri3oNt77IWGHO4 0APff9ECv8URPzek2H8CoB0XwWhHHeKQs+5d9Y/bzVwd2TsiH6t+wJ7HrIRDmMVoJg== X-Gm-Gg: Acq92OF44jIMkgrdYIbMI5BlG27W6j9hRbvlZpirjfmM2WC5ReCHefAVZ0BwEgk9RTZ Vii0FtHBYS/sPlfWXGI8IJX74G1QQwvWuTx/SpYD/7EF+SpsB2Qo9puBCKsQobkRJ10LIZ2k+sO ImQzMS3K2K1q4NQgsnKEikG9Ixn4JxF7FLkTiYmvyoncdt0JQ5T14TuWb/qGE2yawN97q+xTyDH 3zKeBQ7N1PhiPpJUg6EArPbfdwzsV/H7fcRj0vOZIiGg0Xw8upMU6tSiNNZgItmtORiura8FalP c1DeTBiyNUnHWL1eNBq9ZzKX5IbHDc5gksPVKXWucBmywrmMhQ8jirAAnkIqt856Wl67rqKTdbp sjVod51IvuPr/xH/UIqnc/msA07ijm0I4ngsFQSrJqiMacHOClJvZ4GLhjAhlKuU1R8O9Cf+Kx/ ne+S6IvXsQ/lN0DMlwt3ZmOxXyCT6BIPRnx/oZ/FvPkaFPsvovwyM1MxvyMeyFK61OgBJ8QKMif qinVNo= X-Received: by 2002:a05:622a:3cb:b0:516:e93f:826c with SMTP id d75a77b69052e-516e93f846bmr235313531cf.36.1779926754106; Wed, 27 May 2026 17:05:54 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51706adc8f3sm57912571cf.18.2026.05.27.17.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 17:05:52 -0700 (PDT) Date: Wed, 27 May 2026 20:05:52 -0400 Message-ID: <51a1cbe14d3ed32b303d6ed95a69c155@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260527_1931/pstg-lib:20260527_1608/pstg-pwork:20260527_1931 From: Paul Moore To: Oliwier Iwan , selinux@vger.kernel.org Cc: stephen.smalley.work@gmail.com, omosnace@redhat.com, linux-kernel@vger.kernel.org, Oliwier Iwan Subject: Re: [PATCH] selinux: add comments to smp_wmb() calls in status.c References: <20260521223815.67902-1-oliwieriwan@mailbox.org> In-Reply-To: <20260521223815.67902-1-oliwieriwan@mailbox.org> On May 21, 2026 Oliwier Iwan wrote: > > The seqlock pattern used in selinux_status_update_setenforce() and > selinux_status_update_policyload() requires memory barriers to ensure > correct ordering of the sequence counter updates relative to the data > writes. Add comments to the smp_wmb() calls to make this ordering > explicit and self-documenting. > > Signed-off-by: Oliwier Iwan > --- > security/selinux/status.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Thank you for submitting a patch, but I don't believe the comments are necessary. -- paul-moore.com