From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2602CBE5E for ; Mon, 24 Mar 2025 06:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742796974; cv=none; b=IrzZrdl8Q9+J2Y7aB/xfB0f1jgQOwDRjNcm2hzQgbofxNP9JWen96bxfaIB0kW6+rtgPOYVNsIOnLF125o/xJuhbVjA/uSZlNfOXvQ+fq3pN4SW8NMEloVRFgLY2MNvYD0x4WbB5Q9MnFikZAsz8I9dK4ofudmW0PGRY2mgCDfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742796974; c=relaxed/simple; bh=T0fMoQbxKTs+J5RN/iwSWQZM40qUvOQCb8V4cNqTR+k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IcPgmdRL1LVk6Azg3lzaD6rU4BZjWZ6bMzBuIHZdeNYabnN7eGEtwPCgGyL/H9wRU6RWf8tiwTfKUVBbp9csKRPHjryCZejQDS8Un+MoujIqp4HjWPQBUuoUklSitEZyVCkURITDnQTuWwVehXIUpKqPqvuGCDkkFrYC3+DDv1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=craftyguy.net; spf=pass smtp.mailfrom=craftyguy.net; dkim=pass (2048-bit key) header.d=craftyguy.net header.i=@craftyguy.net header.b=AW+seEM8; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=craftyguy.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=craftyguy.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=craftyguy.net header.i=@craftyguy.net header.b="AW+seEM8" Message-ID: <51a59b41-4214-4e24-bfe8-3d8174ba1a3b@craftyguy.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=craftyguy.net; s=key1; t=1742796960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8JLMiI733S4xTq1mEOv/zfYlCWUzTNqm+0T4v8oraU=; b=AW+seEM8/syKljhEMGkSA3KPt7Al/dEjX1dKgxcynyPa3TzM90Nkz9NV5h8KEnLn5A68h3 FxZ6EH8ioKxSvJL8hLKfdMixNTsT1QFvBtLxgxyOianttCUaek8gCrrGfuPeTP8L4ClgDk /oflXwoN9AcoCuO9PVKg40w3+QxUYU0r/IkmqPYasPmFdRgNfNiDACSNNgGvkkf3+046cO 4Wv+hZdpFk9byAk/ls69EtsmpsGckON7smiMeAU+T6Mrv3dhjmYhxhQrl9bNv3OcFeluYF 2Z5lRmC8sbkYx5+7Aj/ikPyxRWFKIhxg2f3ojVkpM27iEeSnQZIfZ/kXVurXSA== Date: Sun, 23 Mar 2025 23:15:54 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] wifi: ath11k: fix rx completion meta data corruption To: Johan Hovold , Jeff Johnson Cc: Miaoqing Pan , Steev Klimaszewski , Jens Glathe , ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250321145302.4775-1-johan+linaro@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Clayton Craft In-Reply-To: <20250321145302.4775-1-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 3/21/25 07:53, Johan Hovold wrote: > Add the missing memory barrier to make sure that the REO dest ring > descriptor is read after the head pointer to avoid using stale data on > weakly ordered architectures like aarch64. > > This may fix the ring-buffer corruption worked around by commit > f9fff67d2d7c ("wifi: ath11k: Fix SKB corruption in REO destination > ring") by silently discarding data, and may possibly also address user > reported errors like: > > ath11k_pci 0006:01:00.0: msdu_done bit in attention is not set > > Tested-on: WCN6855 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41 > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Cc: stable@vger.kernel.org # 5.6 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218005 > Signed-off-by: Johan Hovold > --- > > As I reported here: > > https://lore.kernel.org/lkml/Z9G5zEOcTdGKm7Ei@hovoldconsulting.com/ > > the ath11k and ath12k appear to be missing a number of memory barriers > that are required on weakly ordered architectures like aarch64 to avoid > memory corruption issues. > > Here's a fix for one more such case which people already seem to be > hitting. > > Note that I've seen one "msdu_done" bit not set warning also with this > patch so whether it helps with that at all remains to be seen. I'm CCing > Jens and Steev that see these warnings frequently and that may be able > to help out with testing. > Before this patch I was seeing this "msdu_done bit" an average of about 40 times per hour... e.g. a recent boot period of 43hrs saw 1600 of these msgs. I've been testing this patch for about 10 hours now connected to the same network etc, and haven't seen this "msdu_done bit" message once. So, even if it's not completely resolving this for everyone, it seems to be a huge improvement for me. 0006:01:00.0 Network controller: Qualcomm Technologies, Inc QCNFA765 Wireless Network Adapter (rev 01) ath11k_pci 0006:01:00.0: chip_id 0x2 chip_family 0xb board_id 0x8c soc_id 0x400c0210 ath11k_pci 0006:01:00.0: fw_version 0x11088c35 fw_build_timestamp 2024-04-17 08:34 fw_build_id WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41 Tested-by: Clayton Craft