From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08BD92EA154 for ; Thu, 23 Apr 2026 13:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776952198; cv=none; b=BilTFdNvJIia/91IJzUdAJqDQWItB7Dmp3AYU4TdQmptuRou5s2AmwUt89spfLXxidRT92BHpoOC1HLE0VRnYq/GPwf87Y6bTswozqSn4e8pbt0brrAdJBgZ7huoad4+bo9dTSAOpbH//BMsvwBAschRc53ZWrFKv4EI6SVsDfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776952198; c=relaxed/simple; bh=KWQ7sey/nTnyoLv0JYkF53TFEnPYC0oacWNyHgDCzyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X+lVTxIkDQo5PUO6YyesI5b/wfGo/BvgkCtIU7T00QDP45qljaHMVgI4DCV1LY6FLUDTeJG+eNpsTVpERaU0z7vZCb1MSl2yA3b/nX1NL4MIfyWUPThPP8hrjhEK3sDcKev1pb9uzzQqzclZI70VBhTURHMiTims1PnBEcDmsO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GHnGh6v+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PI+3GZ5s; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GHnGh6v+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PI+3GZ5s" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uEjF3044060 for ; Thu, 23 Apr 2026 13:49:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9dbrtiBN5wfRX/dGpMkwo4KCgT0s/zfntZC2Cu6gWc8=; b=GHnGh6v+XLj2qYF7 CpBQUJ5aj2A1qnCyWc3w9TXtIc4Ph54YpdryPuPk7rXQ0qjJLh4l5PoiV9HkqRWE ubuzjYnT6pF7LocCJncERm4+3Ak5T6Xn/Ljwu1jKlFHqKNQ6EfZkkLx+cj0Zl3Tf urXdUMJ2XKGhFXs85CgA6oUvyW7N6N3nlUCkoL4F48i//w0NwMZOQx1aMKse6iOI 5T3zXNd4YspOrMgKYyNHt8l2kkmwO/M8bUkywRHTxzoGlygt5Bgh8Q4T9TWwARSL yZEJ6fOq2NCAtNJz6Gd5TRk1tgTZ7+TCMLVI/u+NjWSaTtp1relaaqgiGAfdTpVh /WVD9g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh45kh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 13:49:54 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-354c0234c1fso7317094a91.2 for ; Thu, 23 Apr 2026 06:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776952194; x=1777556994; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9dbrtiBN5wfRX/dGpMkwo4KCgT0s/zfntZC2Cu6gWc8=; b=PI+3GZ5sMWOM7gvUfWeTGs/1UjH9O/Jyf+v2Nasg0M0R7NKM6lwG+9f9KvuxSV4uM1 DFLqoBJb8pX0YYVr7dXfO6Vx1jSb39otgAgR9t3MSRyXOQyxH7nkGBp8k7NVl2znsHwB DalCfN6C7Ns9ObeAMn12cPHiBKdiVXBU57MghL+MR5QYzlrAmu1cfc4PUHwZC1T79yVi K+jREKD/KOvM9zJy9ivQGb3Zj50byLKwuNRe6dOWpZEUfxI2+84AwD/Xy1Zd7W9llGbP 0tHYPwFQMfG8Hgf2D8SRAdIA6yCNnDpl/wKn6WqwVvBH08XifeaJTQdH2rf3io3tmqhr lCXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776952194; x=1777556994; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9dbrtiBN5wfRX/dGpMkwo4KCgT0s/zfntZC2Cu6gWc8=; b=sXPHzGY8B4HjOkMwHlCQ2pSeG5ZnRosbTfuy/nohKbwdzP0n+d/RpAw8KJmJtwDk56 uct3wev4P1NRWtAH82W/bE/ZCqz5PeH13KayAOf3K6JLm66C8KsJvOun6FqAKNsgy6Sv KNEVXJ/Vh8bRY5sBlj3hy5tQZwNsJNmAq7Lv34OHU5829zKVu3/0gVpj+TQ52dKPUotu Cz7K05SaH/jIVGj0xPnxP2/WDQe9B7RMXRhH5VgdQRRlNfBxocIAgtMXDTBaZ5ScxQ41 PqmYbecBw6ITeCNxfxADXCuwOgndhDobZsNt3/ggfro9ajTU2H9gInOrAsiy+EUIwdpv k2nA== X-Forwarded-Encrypted: i=1; AFNElJ/Gbreu7KX+tPxsiCDdsdp65e7umOugnoLD3v9JzVrosY0rQZwqyHnKrSWvIzyB5mCb+rJtYa4UxsHer1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/aspEN+oVLI1hryCaTiSVx324dyAGmyL2omHznxOV2U8bzljT pyn6UYOMj4jmxxIQ4IJ36mNuYUnyyGmk2SJ4tFZNTOMkn/8GSQdqmFFTojGtHAT6yE8WTXM6yFJ PUd4qpTneapr6TYOfRmLp0sOQnWEviRFaiS1JIFE6A9oNX2XHHuyW2MyVrsJ8LYvWxf4= X-Gm-Gg: AeBDietkgfvsizIpunQJkycrdUiRS9zwtbGG7y1/fhQCLyZZlxOR2sWPY3h6OUEAEk1 fEEOR+t4Xe4JE8/uV7b+X8RNYKv4vWYeEwjVSA96KWqs8NEBmj/RGpDqp/dUAE969Ff7ycaurVm VzruRBKIws8Ithwy3mvJMR9OxYbjSK9VIuETKVxiGQMVAykLpQaifOIxnIRQ6QWct6KX7qtVaeH NVLZ0h51FKCaaxvOQ+BquXLWxhji5QRXsrttoU4TTKLmwB94NzktVQ7zqKmqnbSyAWQ03PfYeNn Vr0WV2Hw3AjEGXzF8vOVQRxj2gZZX9N0dwaGX+G1FsI50NuuZA2ms+if1RPfO3jVTkIaM6k+MkR k0w0vStyA5cCR8055ZGq9CkTEZiZepopO0sHp+XwXEAqiS09mRyYLZBjX+RT31qbyS99iaWSU6B tS79Itoc1kudtjRSbBanWJ X-Received: by 2002:a05:6a20:72a3:b0:3a3:1f85:645f with SMTP id adf61e73a8af0-3a31f857f4cmr3942167637.18.1776952193813; Thu, 23 Apr 2026 06:49:53 -0700 (PDT) X-Received: by 2002:a05:6a20:72a3:b0:3a3:1f85:645f with SMTP id adf61e73a8af0-3a31f857f4cmr3942125637.18.1776952193329; Thu, 23 Apr 2026 06:49:53 -0700 (PDT) Received: from [10.133.33.37] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe41cfsm22089628b3a.43.2026.04.23.06.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 06:49:52 -0700 (PDT) Message-ID: <51a6fb68-d7b8-4406-b653-b298efae6a75@oss.qualcomm.com> Date: Thu, 23 Apr 2026 21:49:47 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] scsi: ufs: core: Add support to retrieve and store TX Equalization settings To: Bart Van Assche , =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "beanhuo@micron.com" , "mani@kernel.org" , "avri.altman@wdc.com" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "vamshigajjela@google.com" , "rafael.j.wysocki@intel.com" , "alim.akhtar@samsung.com" , "James.Bottomley@HansenPartnership.com" , "adrian.hunter@intel.com" , "linux-kernel@vger.kernel.org" References: <20260419135229.1036926-1-can.guo@oss.qualcomm.com> <20260419135229.1036926-3-can.guo@oss.qualcomm.com> <343283a8281e2fb0ee83622a15028d12e44bd964.camel@mediatek.com> <90c86ccf-5820-4937-b595-a8b47cac9ae9@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <90c86ccf-5820-4937-b595-a8b47cac9ae9@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEzNyBTYWx0ZWRfXzj1sbYjv//rU ciK3h/sl5nUw4/6NBDagJaIxSR2GMZAvTgqF5w+m9quDFlnoVJQrBfBo1BWHGiE3RgpDAKIHkkR T7bSn423GiRHSUqrCwAuSK8oN3o2xVExd4Ljf2kKyKATarRZvWnGCsjb1WCaUXE8y7WOJOEgbZR lCzgmHIzVzR5ezZAAZNz6IXh+sqAv+Xutq4P/rj3SQUNcP1Q0KSflDa6tmay3LDuV4qApjnRcAO 2FNmhvCqYbKh5oACsvyEzy6szYK7dimLK8QW6bl45Ck1eF+16bDfscbTtsCfg93FiguR+EaI03x zrq2xKDb4aNIhf8pvlrDobkGke/vGXjzVOBXAUmRe0GV7MF1qrw+EH9fbBr4uJIztS3fl0r6CUa vFD7Ly5A3ffSmz+bxW6seW8GnAHXiD4TRDWG98Yu4++WWMgHYi/llbPgKXjkg+kpsZ6prDQBWME jX7JLzGIk8h1ahoqniQ== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69ea2382 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=ru4zZYNuDXd2OUl2SekA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: 5Ra0nOOVu5K4QPGLfFKbKiswNcAPBHsT X-Proofpoint-ORIG-GUID: 5Ra0nOOVu5K4QPGLfFKbKiswNcAPBHsT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230137 Hi Bart, On 4/21/2026 12:28 AM, Bart Van Assche wrote: > On 4/20/26 6:23 AM, Can Guo wrote: >> The usage of the two Selectors is not limited to above examples. Yet >> it is hard to get >> aligned on how to use the two Selectors across different companies. >> Hence I am adding >> a module parameter. > > These kernel module parameters can be converted into sysfs attributes, > isn't it? Converting these kernel module parameters into sysfs > attributes has the advantage that different values can be configured per > host controller in systems with multiple UFS host controllers. Thanks for the suggestion. For this series, these knobs are needed before the first HS-G6 power mode change, which happens during early UFS bring-up in probe. At that point, userspace-driven sysfs attributes are not available yet, so relying only on sysfs would miss the first power mode transition. That is why this patch uses module parameters (boot-time configurable via kernel command line). I agree sysfs is better for per-host runtime tuning on multi-controller systems. We can add per-host sysfs controls as a follow-up later on, while keeping boot-time defaults through module parameters for the first-transition requirement. Thanks, Can Guo. > > Thanks, > > Bart.