From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BDE95223; Thu, 13 Mar 2025 01:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741829580; cv=none; b=oX5X0pjoQl1xIGNnOp82+62Fs1RMzUhQmocZXppVliLYkrfE1jS0FlSPQoJi1rPlSE5X8E6ArUGze1jSl6jE/Rz9DnTnuujdZ03w/7xbf/zouFrIHiPz0dp30x8REYtmGKHw94MTCutKAEzZlXhaYXhr36TfcErAbBds3phDhzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741829580; c=relaxed/simple; bh=8MsDECNhD8vbjfpqmnlc7TmVA/WC33SvbE1RXJA5MuA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qDA8oIQtYpwm2oKkszHuQv5eOoekSiifLxMTalP/MqbpXPeve/qylkulZQg6O0/DGbP2ZIkjOhR3vcQdm1oBVgAeK+Zk2Coh0dXqPxmV7QDfa0EWrJ5KdPymXM6+fqJSFkRmlAOWnJjR7IxIsK2Ocr6jq/NPD2/aOHH7B01H5fY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=nSXbwnDb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="nSXbwnDb" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52CMGaIk023865; Thu, 13 Mar 2025 01:32:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jN2qV43lzjZsukbYe7DDtzj/nw01O2ZFlq6+ZGc1jY0=; b=nSXbwnDbgJFhkBSw o4I0fUR8FL+llJBJ8AoeH1sxyiPaqyPJ2Q7fnbnp20hujpHtzqdDH3i4L0wLWVVj +xFcSE4pLad7/Y6nX3Dd19b/xP1aCoe00Ei55UGquq1IiN+1iajXeWST3xklnjzV sLGoYlcGitRj3WXCIqPcseqbsAAtv31UislIwEN63704dBSEnt6XT6gx/BTxun1N W2paZeKdq/usCg9LD/U5UrZFC8D7n4A4YT+62nrYSeKG51qaET7NwdCXD3HgpG4Z R2PpKcGwpcTYNvTxifEJOtxv+C5+9BQCONhC5dIjEbm8eOGV+T9OImR51we4qny9 o3zgNw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45au2mm50e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Mar 2025 01:32:22 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 52D1WL6M032557 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Mar 2025 01:32:21 GMT Received: from [10.64.68.153] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 12 Mar 2025 18:32:16 -0700 Message-ID: <51aab2c3-2219-454f-93b1-5820a9c2ced1@quicinc.com> Date: Thu, 13 Mar 2025 09:32:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] coresight: tmc: Introduce new APIs to get the RWP offset of ETR buffer To: Mike Leach CC: Suzuki K Poulose , James Clark , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Tingwei Zhang , Jinlong Mao , , , , , , References: <20250310090407.2069489-1-quic_jiegan@quicinc.com> <20250310090407.2069489-2-quic_jiegan@quicinc.com> Content-Language: en-US From: Jie Gan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: RA-IN6iOG2SlSoI-qxq2UU325fK7wnyE X-Authority-Analysis: v=2.4 cv=aKnwqa9m c=1 sm=1 tr=0 ts=67d235b6 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=lQ6WigISvc1pitc9guYA:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: RA-IN6iOG2SlSoI-qxq2UU325fK7wnyE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-13_01,2025-03-11_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=714 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503130011 On 3/12/2025 8:54 PM, Mike Leach wrote: > Hi Jie, > > On Wed, 12 Mar 2025 at 01:21, Jie Gan wrote: >> >> >> >> On 3/12/2025 12:49 AM, Mike Leach wrote: >>> Hi, >>> >>> On Mon, 10 Mar 2025 at 09:04, Jie Gan wrote: >>>> >>>> The new functions calculate and return the offset to the write pointer of >>>> the ETR buffer based on whether the memory mode is SG, flat or reserved. >>>> The functions have the RWP offset can directly read data from ETR buffer, >>>> enabling the transfer of data to any required location. >>>> >>>> Signed-off-by: Jie Gan >>>> --- >>>> .../hwtracing/coresight/coresight-tmc-etr.c | 40 +++++++++++++++++++ >>>> drivers/hwtracing/coresight/coresight-tmc.h | 1 + >>>> 2 files changed, 41 insertions(+) >>>> >>>> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c >>>> index eda7cdad0e2b..ec636ab1fd75 100644 >>>> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c >>>> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c >>>> @@ -267,6 +267,46 @@ void tmc_free_sg_table(struct tmc_sg_table *sg_table) >>>> } >>>> EXPORT_SYMBOL_GPL(tmc_free_sg_table); >>>> >>>> +static long tmc_flat_resrv_get_rwp_offset(struct tmc_drvdata *drvdata) >>>> +{ >>>> + dma_addr_t paddr = drvdata->sysfs_buf->hwaddr; >>>> + u64 rwp; >>>> + >>> >>> It is not valid to read RWP if the TMC is running. It must be in the >>> stopped or disabled state - see the specifications for TMC /ETR >>> >>> It is likely that CSUNLOCK / CSLOCK are needed here too, along with >>> the spinlock that protects drvdata >>> >>> See the code in coresight_tmc_etr.c :- >>> >>> e.g. in >>> >>> tmc_update_etr_buffer() >>> >>> ... >>> >>> ... >>> CS_UNLOCK(drvdata->base); >>> tmc_flush_and_stop(drvdata); // this ensures tmc is stopped and >>> flushed to memory - essential to ensure full formatted frame is in >>> memory. >>> tmc_sync_etr_buf(drvdata); // this function reads rwp. >>> CS_LOCK(drvdata->base); >>> >>> >>> This type of program flow is common to both sysfs and perf handling of >>> TMC buffers. >> >> Hi Mike, >> >> I am fully understood your point here. >> >> The function is designed this way to read the w_offset (which may not be >> entirely accurate because the etr buffer is not synced) when the > > Why would you ever base memory access on a pointer that is not > entirely accurate? > > The manuals for TMC/ETR all state that reads to both RWP and RRP when > the ETR is running return unknown values. These cannot be used to > access the buffer, or determine how much of the buffer has been used > on a running ETR. > > The ETR specification specifically states that it is not permitted to > read the buffer data while the ETR is running, when configured in > circular buffer mode - which is the mode used in the TMC-ETR linux > drivers. > > Reading the buffer while ETR is running is only permitted if > configured in Software FIFO mode 2 - were the ETR will stop on full > and stall incoming trace until some data is read out, signalled to the > ETR via the RURP. > Hi Mike, I appreciate for your patient explanation. I was wrong about read data from etr_buffer. I must follow the specification to design a method to reading buffer while ETR is running. How about the following method: 1. The byte-cntr interrupt handler will count the IRQ triggered number when byte-cntr file node is opened. 2. Read the buffer after the ETR is stopped(full or stopped manually) according to the counted number. we got the etr->offset, etr->size and the counted number, so we can calculate the offset where starts to read. 3. Restart the ETR to keep counting the number of IRQ triggers. Thanks, Jie > I also note that you are reading back the etr_buf data without doing > any dma_sync operations that the perf and sysfs methods in the driver > do, after stopping the tmc. > >> byte-cntr devnode is opened, aiming to reduce the length of redundant >> trace data. In this case, we cannot ensure the TMC is stopped or >> disabled. > > The specification requires that you must ensure the TMC is stopped to > read these registers. > > >> The byte-cntr only requires an offset to know where it can >> start before the expected trace data gets into ETR buffer. >> >> The w_offset is also read when the byte-cntr function stops, which >> occurs after the TMC is disabled. >> >> Maybe this is not a good idea and I should read r_offset upon open? >> The primary goal for byte-cntr is trying to transfer useful trace data >> from the ETR buffer to the userspace, if we start from r_offset, a large >> number of redundant trace data which the user does not expect will be >> transferred simultaneously. >> >> > > It is difficult to justify adding code to a driver that does not > correspond to the specification of the hardware device. > > Regards > > Mike > >>> >>>> + rwp = tmc_read_rwp(drvdata); >>>> + return rwp - paddr; >>>> +} >>>> + >>>> +static long tmc_sg_get_rwp_offset(struct tmc_drvdata *drvdata) >>>> +{ >>>> + struct etr_buf *etr_buf = drvdata->sysfs_buf; >>>> + struct etr_sg_table *etr_table = etr_buf->private; >>>> + struct tmc_sg_table *table = etr_table->sg_table; >>>> + long w_offset; >>>> + u64 rwp; >>>> + >>> >>> Same comments as above >>> >>>> + rwp = tmc_read_rwp(drvdata); >>>> + w_offset = tmc_sg_get_data_page_offset(table, rwp); >>>> + >>>> + return w_offset; >>>> +} >>>> + >>>> +/* >>>> + * Retrieve the offset to the write pointer of the ETR buffer based on whether >>>> + * the memory mode is SG, flat or reserved. >>>> + */ >>>> +long tmc_get_rwp_offset(struct tmc_drvdata *drvdata) >>>> +{ >>>> + struct etr_buf *etr_buf = drvdata->sysfs_buf; >>>> + >>> >>> As this is an exported function, please ensure that the inputs are >>> valid - check the pointers >> >> Sure, will do. >> >> Thanks, >> Jie >> >>> >>> Code to ensure TMC is flushed and stopped could be inserted here. >>> >>> Regards >>> >>> Mike >>> >>>> + if (etr_buf->mode == ETR_MODE_ETR_SG) >>>> + return tmc_sg_get_rwp_offset(drvdata); >>>> + else if (etr_buf->mode == ETR_MODE_FLAT || etr_buf->mode == ETR_MODE_RESRV) >>>> + return tmc_flat_resrv_get_rwp_offset(drvdata); >>>> + else >>>> + return -EINVAL; >>>> +} >>>> +EXPORT_SYMBOL_GPL(tmc_get_rwp_offset); >>>> + >>>> /* >>>> * Alloc pages for the table. Since this will be used by the device, >>>> * allocate the pages closer to the device (i.e, dev_to_node(dev) >>>> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h >>>> index b48bc9a01cc0..baedb4dcfc3f 100644 >>>> --- a/drivers/hwtracing/coresight/coresight-tmc.h >>>> +++ b/drivers/hwtracing/coresight/coresight-tmc.h >>>> @@ -442,5 +442,6 @@ void tmc_etr_remove_catu_ops(void); >>>> struct etr_buf *tmc_etr_get_buffer(struct coresight_device *csdev, >>>> enum cs_mode mode, void *data); >>>> extern const struct attribute_group coresight_etr_group; >>>> +long tmc_get_rwp_offset(struct tmc_drvdata *drvdata); >>>> >>>> #endif >>>> -- >>>> 2.34.1 >>>> >>> >>> >> > > > -- > Mike Leach > Principal Engineer, ARM Ltd. > Manchester Design Centre. UK