From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EFCC433E2 for ; Sat, 11 Jul 2020 01:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E44CC2077D for ; Sat, 11 Jul 2020 01:44:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mymailcheap.com header.i=@mymailcheap.com header.b="rOmiQrfX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=flygoat.com header.i=@flygoat.com header.b="O9Cz3ZLJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbgGKBoZ (ORCPT ); Fri, 10 Jul 2020 21:44:25 -0400 Received: from relay5.mymailcheap.com ([159.100.241.64]:37458 "EHLO relay5.mymailcheap.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbgGKBoZ (ORCPT ); Fri, 10 Jul 2020 21:44:25 -0400 X-Greylist: delayed 517 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 Jul 2020 21:44:22 EDT Received: from relay1.mymailcheap.com (relay1.mymailcheap.com [144.217.248.100]) by relay5.mymailcheap.com (Postfix) with ESMTPS id DA2A320151; Sat, 11 Jul 2020 01:35:43 +0000 (UTC) Received: from filter1.mymailcheap.com (filter1.mymailcheap.com [149.56.130.247]) by relay1.mymailcheap.com (Postfix) with ESMTPS id 5D5353ECE3; Fri, 10 Jul 2020 21:35:41 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by filter1.mymailcheap.com (Postfix) with ESMTP id 3462B2A3AA; Fri, 10 Jul 2020 21:35:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mymailcheap.com; s=default; t=1594431341; bh=td3lNQCQOo/Xhy8UHkkmlIUHbYQuYTGRjr9288xceGU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=rOmiQrfX3evRYDZdoRc6ljvur+cXM6iwx29vn1es1p2Z63Ol3llCAHR2U45KdI+vp OrIh/l1uWRnlMwqqBeNEk/ZT6sCUvr+BHtVVT4kJHNqfGZuXYcNbDxAKSjn/8+WFpH dRORu8sn+3bCv11e9HE8PmHggTYegN7FFEdX8mU8= X-Virus-Scanned: Debian amavisd-new at filter1.mymailcheap.com Received: from filter1.mymailcheap.com ([127.0.0.1]) by localhost (filter1.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LI7zgvur8FX1; Fri, 10 Jul 2020 21:35:38 -0400 (EDT) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter1.mymailcheap.com (Postfix) with ESMTPS; Fri, 10 Jul 2020 21:35:38 -0400 (EDT) Received: from [213.133.102.83] (ml.mymailcheap.com [213.133.102.83]) by mail20.mymailcheap.com (Postfix) with ESMTP id 485D4413E2; Sat, 11 Jul 2020 01:35:36 +0000 (UTC) Authentication-Results: mail20.mymailcheap.com; dkim=pass (1024-bit key; unprotected) header.d=flygoat.com header.i=@flygoat.com header.b="O9Cz3ZLJ"; dkim-atps=neutral AI-Spam-Status: Not processed Received: from [0.0.0.0] (unknown [38.39.233.131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 9AC36413E2; Sat, 11 Jul 2020 01:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=flygoat.com; s=default; t=1594431317; bh=td3lNQCQOo/Xhy8UHkkmlIUHbYQuYTGRjr9288xceGU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=O9Cz3ZLJ++0Ayk365splSEyw3l6As35wTIllbvmxoT2Ygss8l5Wssxm/q3XDC6dK7 QTOew2nSJ0W0Rj6ybK7Nbh7OxFnFgb/65nEVlqV6BzlwVyiCbM+vmBDgej8XGpqLeQ X5WsZOqyvLv3nBT1DGphs9EeMwyPEtd95ZXPDRUw= Subject: Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip To: Zhi Li , peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lixuefeng@loongson.cn, chenhc@lemote.com, yangtiezhu@loongson.cn, Hongbin Li References: <1594371110-7580-1-git-send-email-lizhi01@loongson.cn> From: Jiaxun Yang Message-ID: <51aeec81-400f-c63b-3a22-e5384ff848f8@flygoat.com> Date: Sat, 11 Jul 2020 09:35:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1594371110-7580-1-git-send-email-lizhi01@loongson.cn> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 485D4413E2 X-Spamd-Result: default: False [1.40 / 10.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[flygoat.com:s=default]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_SOFTFAIL(0.00)[~all]; ML_SERVERS(-3.10)[213.133.102.83]; DKIM_TRACE(0.00)[flygoat.com:+]; DMARC_POLICY_ALLOW(0.00)[flygoat.com,none]; RCPT_COUNT_TWELVE(0.00)[13]; RCVD_IN_DNSWL_NONE(0.00)[213.133.102.83:from]; DMARC_POLICY_ALLOW_WITH_FAILURES(0.00)[]; FREEMAIL_TO(0.00)[loongson.cn,st.com,synopsys.com,davemloft.net,kernel.org,gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:213.133.96.0/19, country:DE]; RCVD_COUNT_TWO(0.00)[2]; SUSPICIOUS_RECIPS(1.50)[]; HFILTER_HELO_BAREIP(3.00)[213.133.102.83,1] X-Rspamd-Server: mail20.mymailcheap.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/7/10 16:51, Zhi Li дµÀ: > Add gmac platform data to support LS7A bridge chip. > > Co-developed-by: Hongbin Li > Signed-off-by: Hongbin Li > Signed-off-by: Zhi Li > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > index 272cb47..dab2a40 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > @@ -138,6 +138,24 @@ static const struct stmmac_pci_info snps_gmac5_pci_info = { > .setup = snps_gmac5_default_data, > }; > > +static int loongson_default_data(struct pci_dev *pdev, struct plat_stmmacenent_data *plat) > +{ > + common_default_data(plat); > + > + plat->bus_id = pci_dev_id(pdev); > + plat->phy_addr = 0; > + plat->interface = PHY_INTERFACE_MODE_GMII; > + > + plat->dma_cfg->pbl = 32; > + plat->dma_cfg->pblx8 = true; > + > + return 0; > +} > + > +static struct stmmac_pci_info loongson_pci_info = { > + .setup = loongson_default_data; > +}; > + > /** > * stmmac_pci_probe > * > @@ -204,6 +222,8 @@ static int stmmac_pci_probe(struct pci_dev *pdev, > res.addr = pcim_iomap_table(pdev)[i]; > res.wol_irq = pdev->irq; > res.irq = pdev->irq; > + if (pdev->vendor == PCI_VENDOR_ID_LOONGSON) > + res.lpi_irq = pdev->irq + 1; This can never work. We're allocating IRQs by irq_domain, not ID. Please describe IRQ in DeviceTree, and *DO NOT* sne dout untested patch. Thanks. > > return stmmac_dvr_probe(&pdev->dev, plat, &res); > } > @@ -273,11 +293,13 @@ static SIMPLE_DEV_PM_OPS(stmmac_pm_ops, stmmac_pci_suspend, stmmac_pci_resume); > > #define PCI_DEVICE_ID_STMMAC_STMMAC 0x1108 > #define PCI_DEVICE_ID_SYNOPSYS_GMAC5_ID 0x7102 > +#define PCI_DEVICE_ID_LOONGSON_GMAC 0x7a03 > > static const struct pci_device_id stmmac_id_table[] = { > { PCI_DEVICE_DATA(STMMAC, STMMAC, &stmmac_pci_info) }, > { PCI_DEVICE_DATA(STMICRO, MAC, &stmmac_pci_info) }, > { PCI_DEVICE_DATA(SYNOPSYS, GMAC5_ID, &snps_gmac5_pci_info) }, > + { PCI_DEVICE_DATA(LOONGSON, GMAC, &loongson_pci_info) }, > {} > }; > - Jiaxun