From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5E5F1EF09B for ; Mon, 6 Apr 2026 03:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775447351; cv=none; b=Pw4x5YeAf36f4SW5a4/HMtYv4n8nmHsQKsmEKx+rBfIuGMdwvLAHbRvpdS4pqppgyx7QB8dnHlNYoI98cWr5ET0CHm797ezAjsLGiVkXS7p+XGi9Rl91qZNUOeOL63jfMfTNCDH3Evc0OdVGvv/p8hDWkdyhEnei96XK2cdCaK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775447351; c=relaxed/simple; bh=TlTVsunSfixzAFsGvAOwd9wYDz24NEgIjzO47N7EVqg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=JJaymDi/kMM5pfof2Z6+VcmuOWkou17O7UR1c9F5wicCMdiBrmxnmQ6V6zUuP3tS/LBEEqbzYL/kvdQM1iEWX7ZGzx582nfMFJjJR4mRLr49MMvdu3WQX9O4hT+cCoMejiNaS1y6uVXgSkOO94pMk41I5IZC0zZssnYFY0Zarvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DOeOpI3q; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DOeOpI3q" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso15558245ad.1 for ; Sun, 05 Apr 2026 20:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775447350; x=1776052150; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=0BKCAT7lBswurLoR7rMAQLaCTljOPGjzlcHbLP4ufpU=; b=DOeOpI3q4GUahaAWXNyT0PzWAuYt3enTeyOpLDSMy8uxYd9cEUoaXy+9JvwFvHhWYF Z6bHz4zniwvJp5v7ba2kFrPALolgoi+B+brY+vgqEMD8Iu3M9R0jrNLSSmsfkdYZA3X1 RSR5aWKWIoUMaoYrkMzC7rKgG56IpKF9QmwMiwkFtBWs2eXUrx7lDW/PKdqdeQfpYTHi 9chOfTTT/Csn0LW3CRtPLR+xurqF3BtFFkekbtqbI6P0rlR0C/C8zyPP2dSVK8U5CfG8 /bWA+S5RTUNKdhGof/XqV/i3XQZYvJkGe7gRsLqxz2zpAIjo9SePy6YPV8KP/K97iCEL u4Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775447350; x=1776052150; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0BKCAT7lBswurLoR7rMAQLaCTljOPGjzlcHbLP4ufpU=; b=GUOK9WcWJgYRYZHs84MRbxQ4DRRLlMMg0kPC75z7ze/eO/7cWGAV/rKZnSMtNk5GxW tYoC3dQXGAuMbAETYX6nNRpeS6yyARCa0P9eH8WqOSbBD2nmD5UZSvkCFmGyIhJ6HWLv ss7CbSJV15TX5vx/520r0DwRLN5AL4x4FA3AF2xKrf4qh+r9TSu7z4GvqU+WjtjThOMl CiTSLutOHdO7pWfPyn3lHvtLOQkS00qzbZlAfPqlPycVUCArDyfda2gCb7i/nSPvQRSc 3bUIK0mIwWIxxmsWCMF8feGgCU3nLtUFzHiv3XYDKJRdL6i3c4XRBt7shwOPQ2taUo+3 HTww== X-Forwarded-Encrypted: i=1; AJvYcCXKPOoMwFUZ/KQyaHPhjSKddhEgdCBMFvQEYVoiGSyFkkg1tCUvb12hS8Sv1hvE7bXMD+SdjVUwtkFoQvY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmot+3+QYuxx5URLTrXdyyaQmNUwYOXuyFdvC47aTeQUinSPzS EbyVDLk5nbC/DM7ac/pQ0SPxEWmBx1ah2KyegZnldeRO0GrK7qMhkhq/ X-Gm-Gg: AeBDieuo2ouFxVNAsmEEIV454XUhzSRzeFDdGM2HQlEAVcbijf1b9Y7U2aeWHI1mGXu D1yXCZhVVDyki4+wuLDDCLmd7EvnRxVukSYegVawa0rIP843HPPhViH/QeaTHOoUqgl2d0u630o X+8ZpdwK0oG4iRcJaHrxlaP7j3tMBBDixuEagcLCK1Epf1u6iyU090jyvupCaOvMOivUdp4g7YE Kv5PAzloqkYOSvZ3Ma5qorQuHfC8hFR7EH4iKZ7NTQRvZvpCl07zjLo1NCm4FHJv6dq8IyslMV8 1lhmzYY+MOyhVezMqcaGDJuJI6ETWNr2sTM9opovNZkE0yjZxNi5ZMgC/0lyUUMpevpRrcu4fmx AeouPDUW1w1UO52sBCn871qLGkq73s2AN+IQKam8DtdB2d4lSjqVBclp9OMBlzAOR9+hqCjkOsH AmZ2OFsFJiN9E+MhSpUD0M+fnBO17wLciVi59OsRrIsDgY+pN0BlhC9vefYMPDzPkT29byBXQhM azmFmH/HmmHVjfETASsYou2CIB9nMC1YvqWlbHFoy8fVhO5MQ== X-Received: by 2002:a17:903:388f:b0:2b0:708f:4dc7 with SMTP id d9443c01a7336-2b281789c6dmr125370095ad.29.1775447350149; Sun, 05 Apr 2026 20:49:10 -0700 (PDT) Received: from ?IPV6:2401:d002:300f:4a00:69b1:854d:1478:44a6? (7zyfljft9qk2ch4xzw86.ip6.superloop.au. [2401:d002:300f:4a00:69b1:854d:1478:44a6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27475bc2asm128031385ad.19.2026.04.05.20.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Apr 2026 20:49:09 -0700 (PDT) Message-ID: <51b03477-8007-4d43-aa09-39b80dec931a@gmail.com> Date: Mon, 6 Apr 2026 13:49:07 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] leds: syscon: Add tristate option From: Bevan Weiss To: Lee Jones Cc: Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260308015824.2318366-1-bevan.weiss@gmail.com> <20260308015824.2318366-2-bevan.weiss@gmail.com> <20260319101327.GH554736@google.com> <20260319223335.5e1913a4@openwrt-virtual-machine> Content-Language: en-AU In-Reply-To: <20260319223335.5e1913a4@openwrt-virtual-machine> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/03/2026 10:33 pm, Bevan Weiss wrote: >>> +MODULE_LICENSE("GPL"); >> >> The MODULE_LICENSE() string should match the SPDX identifier at the >> top of the file. >> > > Sorry, I'm not quite understanding this in the context of other files. > Most modules within the led subsystem seem to have > 'GPL-2.0-or-later' as the SPDX identifier, and MODULE_LICENSE("GPL"), > as I currently have here. > Is there a different subtlety I'm missing? > e.g. leds-adp5520.c, leds-as3668.c, leds-blinkm.c > Perhaps MODULE_LICENSE("GPL v2+")? although I don't see similar > anywhere in the kernel. > I'd expect MODULE_LICENSE("GPL v2") to be for 'GPL-2.0-only' licenses. > I've got a v3 mostly ready to send, but was hoping for resolution of the MODULE_LICENSE query before submitting. Can I proceed with MODULE_LICENSE("GPL")? If not, what value should be here? Regards, Bevan Weiss