From: "Arnd Bergmann" <arnd@arndb.de>
To: "Daniel Thompson" <daniel.thompson@linaro.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Jason Wessel" <jason.wessel@windriver.com>,
kgdb-bugreport@lists.sourceforge.net,
"Doug Anderson" <dianders@chromium.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdb: include header in signal handling code
Date: Fri, 30 Jun 2023 17:31:01 +0200 [thread overview]
Message-ID: <51b8b3c2-f4ac-454c-acde-e1d136139109@app.fastmail.com> (raw)
In-Reply-To: <20230630152439.GA2900969@aspen.lan>
On Fri, Jun 30, 2023, at 17:24, Daniel Thompson wrote:
> On Wed, May 17, 2023 at 02:54:09PM +0200, Arnd Bergmann wrote:
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index 8f6330f0e9ca..d38df14f71ac 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -4780,6 +4780,8 @@ void __init signals_init(void)
>>
>> #ifdef CONFIG_KGDB_KDB
>> #include <linux/kdb.h>
>> +#include "debug/kdb/kdb_private.h"
>> +
>
> Isn't is better to move the prototype for kdb_send_sig() into
> linux/kdb.h instead?
>
> That's what other kdb helpers spread across the kernel do
> (kdb_walk_kallsyms() for example).
Right, that is probably better here. Not sure if it's worth
reworking the branch if you already merged it, the difference
seems rather minor.
Arnd
next prev parent reply other threads:[~2023-06-30 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:54 Arnd Bergmann
2023-05-17 15:43 ` Doug Anderson
2023-05-17 18:56 ` Kees Cook
2023-06-30 15:24 ` Daniel Thompson
2023-06-30 15:31 ` Arnd Bergmann [this message]
2023-06-30 15:39 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b8b3c2-f4ac-454c-acde-e1d136139109@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=dvyukov@google.com \
--cc=jason.wessel@windriver.com \
--cc=keescook@chromium.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®