From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbdEaLYJ (ORCPT ); Wed, 31 May 2017 07:24:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:51215 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751009AbdEaLYI (ORCPT ); Wed, 31 May 2017 07:24:08 -0400 Subject: Re: [PATCH 3/7] nvmet: add eui64 field to nvme_ns and populate via configfs To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170530092510.GB16736@lst.de> <20170531094631.GC10718@lst.de> From: Johannes Thumshirn Message-ID: <51b921ed-e9f9-0eb2-7625-6053dbca6a82@suse.de> Date: Wed, 31 May 2017 13:24:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170531094631.GC10718@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2017 11:46 AM, Christoph Hellwig wrote: > On Tue, May 30, 2017 at 11:45:25AM +0200, Johannes Thumshirn wrote: >> Mostly consistency. The current nvme host code has the EUI sprinkled all >> around. Sure I can drop it, but then what's the point in evaluating it >> on the host side? Other targets may send it, so we need in on the host >> and do we care about potentially awkward host implementations with Linux >> as a target? Also it's rather handy for testing as well, after all it's >> not too much and complex code. > > There's only one place in the host code proper (discounting the > scsi translation mess), and that's because the field is still better > than not having any uniqueue identifier. But I don't think we should > spread it any further. OK I'll drop it in my next re-send (which should hopefully be somewhen today) -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850