From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CAA737C92A for ; Mon, 3 Aug 2026 16:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785773497; cv=none; b=MENT/x41BN5UTexgti8v8gLPPD/9UvCB3HjiZB0KzIZCdBpTBD/Sngc3KsZmy89SNo0qi/QnMEAqvwSgXp0/VBLXj2kffqfQwLap+iI7JMkssqkJSNNQY2QflfpC4SEIsmNNFj9xftwLhrx0+0cpF4/Bk1WOZ9cvMfhbhSkHvuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785773497; c=relaxed/simple; bh=+QALvQiHMlQRwY0nMxJePPGFDWDjCRk+5uGBf54egKk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ijhfhaI6k+He31Cr1AdnrBJfO4HtF9Y+VN3rkfWnpZTaJFUwPUvqCPBjBM+Gokiytzzu/QKFIuSrjwDmPEKc4ghidxpO1p+h4NZkZqYlXwh/97iisDFGU0pUJaflWfA9lnTiBxW7PyGGTWzhx++6sfM7tgYoYguyNbkA2TJ4u6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n+7JQ2wK; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n+7JQ2wK" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so12696905e9.1 for ; Mon, 03 Aug 2026 09:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785773490; x=1786378290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l/erqd8k66TTCAw8PMmbwYLxInnN4rdx5bNv3CpPzY8=; b=n+7JQ2wKrkqztNqPkoYHLhfh/UbapJBNizdIxbU4/ZJObibdSAiVLKKItwAFF82TXd ISHpx82sBuPxlw34nC08YvX+/KCt/RwrPodBFlkcScoy7BsvXUGttKP66zEpPUW5XCBG jtPck/Kx0WqugyH8EQLEiO2hutN8ois+UzKuGipnzO3W5I7hGo5byLF7ghhKz6y+lrai 0o1B9QF2sPUefvJcNfpLaE/9KjY2ZNxMLXCJlIE3C/QW2rUqCs4Ab3TSb8UYNqcrNT9E 31v3NOsvi/cQZHHyqAXs3SRUgdqX8MZs49YjCogROmp03+CCv74MKQIhi+u5n7cekWE7 Bf0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785773490; x=1786378290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=l/erqd8k66TTCAw8PMmbwYLxInnN4rdx5bNv3CpPzY8=; b=AhZeahFelLh3iiFRka96oopbyN1Py2hUpVQ9s0XVnHzpDiFeKRJpWC/j/vLwdc03SI TPKXKpHXq0b1PQdxRL58OpIn5TWiIt3K7svjcx3gnVgM1QX580cDlUBc/oV5t6ILH5OE rlgcIzj5iByz5Pd0yhDv3dgxkW8OeucJgdr/IUDNQsNw2k/gSU2x1C82iaSmfV9eRHt5 Q1q47ALued76BIUlhZv7tcGyHiQZef3J8eABvPL2GrFLzXg/QZCLpNIGUNwGFNST8vEh faVQq3WJnWppQ0ddjo4+iyBhH0+MeAHEZBTrKNNAHxS0kORlWX3B4vSPeaezoFwXmyVF Owog== X-Forwarded-Encrypted: i=1; AHgh+RownOvC/9imK7mkG4fQ5DzXVyCKj7LcE7s2VXI7zQKn7TxLisgU5CS5QMX5rLqCvdq52lMTHlR/+1jvO0M=@vger.kernel.org X-Gm-Message-State: AOJu0YyQZNdCi4FYb8UKRJP/LUdvJ/ZmOL788amuQye9zk2jeyZXaFQd csuI601P6Zl7wNtMcimpHtdiBrn+AguUjR9wUQ3lki/C+B8LumtWom5g X-Gm-Gg: AR+sD137M/aNfMtGL8T/v4sp4KigRZ8t1ShNXWXFoGQuI+p5sncDubz4EWH66hWwjc0 504C/ZRHq34YGv6OzsMqf40uZCOIlPCZHtd+pWA2wh0Xm7XoIOzGaAe8EfEtkvmvGx5Pm4poTX7 G4kSb2J2JwZIvASKY1s4VnDJiOkkCp6NMRv7uMXQ2K7Kn8Aic5brDLt6k8gv2QFjJXzqQ4MYjGg sSPRNDE8gj5utz5ob475IgoT0meb+vsQm3dMhKWg1GGGsm7kDr+gXq16b1DAWcr+Qc5G9uX6tnE tyZP3j8CBtdcjx16tZUbofbjwBrhBNcAmC8JyorSFCjMifI7HLux7Wmeq5raAvSmIBsAq2Qt+Z5 ENV/hqLLTVmfCggrO2J4ZiIdi2V1hu7aDWBunX3D+mphC1ypgT0pGpgK6m7nuh8ZJrbmDQDAsqU VfJsp1pSnRiPVGfSei+kC3OTv/jxdapRW4/vtbo/icN5CBF0QqJZhl+kqfRSCOYa0Tx+zluMWNh pgb3U6XRJ81KF8irh8ATzuksAvUT18dUZ7RZsk6jD5axAtzdbwAX+ut4/UfuFCn2lbV8TaEwptQ CGNYMhAHx9akwQ21MI+TFUHstZL9U/pfyjK7VvkDBJwnbjwtFNNycCVyHkyupWeUkwyXqk1PC9o JPMnYcvx62SiYBVPEXek3vFxC2uvMf01O1uUN2wqx7lolxMjO+fuDeS9Buu5KIJBHgokrHwLX0T kQow== X-Received: by 2002:a05:600c:3f0d:b0:495:4cb6:71cc with SMTP id 5b1f17b1804b1-4980c66b530mr267029485e9.5.1785773490118; Mon, 03 Aug 2026 09:11:30 -0700 (PDT) Received: from jernej-laptop (APN-122-100-117-gprs.simobil.net. [46.122.100.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fc2da2sm3363735e9.3.2026.08.03.09.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 09:11:29 -0700 (PDT) From: Jernej Skrabec To: wens@kernel.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 07/13] drm/sun4i: hdmi: Don't leak sync polarity bits into packet control Date: Mon, 3 Aug 2026 18:10:45 +0200 Message-ID: <51ba0918ce016a4b45313d5df1b6ce31b8c8731e.1785772659.git.jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sun4i_hdmi_enable() keeps using the same variable after it programmed the video timing polarity register with it. The leftover TX_CLK, HSYNC and VSYNC bits are then ORed into the packet control register, where each nibble selects the packet type sent in one slot. As a result, slot 0 selects packet type 3 instead of the AVI infoframe whenever the mode has positive HSYNC polarity, and the TX_CLK bits set nibbles which the driver never programs. Assign the packet types instead of ORing them into the stale value. Fixes: 9ca6bc246035 ("drm/sun4i: hdmi: Move mode_set into enable") Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 74c7c3720ba8..a27d394d0570 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -161,7 +161,7 @@ static void sun4i_hdmi_enable(struct drm_encoder *encoder, drm_atomic_helper_connector_hdmi_update_infoframes(connector, state); - val |= SUN4I_HDMI_PKT_CTRL_TYPE(0, SUN4I_HDMI_PKT_AVI); + val = SUN4I_HDMI_PKT_CTRL_TYPE(0, SUN4I_HDMI_PKT_AVI); val |= SUN4I_HDMI_PKT_CTRL_TYPE(1, SUN4I_HDMI_PKT_END); writel(val, hdmi->base + SUN4I_HDMI_PKT_CTRL_REG(0)); -- 2.43.0