From: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: <lpieralisi@kernel.org>, <kwilczynski@kernel.org>,
<manivannan.sadhasivam@linaro.org>, <robh@kernel.org>,
<bhelgaas@google.com>, <krzk+dt@kernel.org>,
<neil.armstrong@linaro.org>, <abel.vesa@linaro.org>,
<kw@linux.com>, <conor+dt@kernel.org>, <vkoul@kernel.org>,
<kishon@kernel.org>, <andersson@kernel.org>,
<konradybcio@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_qianyu@quicinc.com>, <quic_krichai@quicinc.com>,
<quic_vbadigan@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: qcs615-ride: Enable PCIe interface
Date: Wed, 18 Jun 2025 15:01:15 +0800 [thread overview]
Message-ID: <51ba2ae0-50fd-4fbe-acc0-3e9f89a75049@quicinc.com> (raw)
In-Reply-To: <6vfwiii4sawm722odw6hxomtsrd5m64pmjlqm5sr5m3nblih3m@jkn3txak5nix>
On 6/18/2025 12:33 AM, Manivannan Sadhasivam wrote:
> On Tue, May 27, 2025 at 03:20:36PM +0800, Ziyue Zhang wrote:
>> From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>>
>> Add platform configurations in devicetree for PCIe, board related
>> gpios, PMIC regulators, etc.
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>> Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 42 ++++++++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 2b5aa3c66867..c59647e5f2d6 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -217,6 +217,23 @@ &gcc {
>> <&sleep_clk>;
>> };
>>
>> +&pcie {
>> + perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
>> + wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
>> +
>> + pinctrl-0 = <&pcie_default_state>;
>> + pinctrl-names = "default";
>> +
>> + status = "okay";
>> +};
>> +
>> +&pcie_phy {
>> + vdda-phy-supply = <&vreg_l5a>;
>> + vdda-pll-supply = <&vreg_l12a>;
>> +
>> + status = "okay";
>> +};
>> +
>> &pm8150_gpios {
>> usb2_en: usb2-en-state {
>> pins = "gpio10";
>> @@ -244,6 +261,31 @@ &rpmhcc {
>> clocks = <&xo_board_clk>;
>> };
>>
>> +&tlmm {
>> + pcie_default_state: pcie-default-state {
>> + clkreq-pins {
>> + pins = "gpio90";
>> + function = "pcie_clk_req";
>> + drive-strength = <2>;
>> + bias-pull-up;
>> + };
>> +
>> + perst-pins {
>> + pins = "gpio101";
>> + function = "gpio";
>> + drive-strength = <2>;
>> + bias-pull-down;
> Are you sure that the default state of the pin should be 'pull down'? Pull down
> of a PERST# is deassert, which should only happen once the power and refclk are
> stable.
>
> - Mani
Hi Mani,
pull-down is assert, we need to make sure perset is asserted before refclk is
stable.
BRs
Ziyue
next prev parent reply other threads:[~2025-06-18 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 7:20 [PATCH v5 0/4] pci: qcom: Add QCS615 PCIe support Ziyue Zhang
2025-05-27 7:20 ` [PATCH v5 1/4] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Update pcie phy bindings for QCS615 Ziyue Zhang
2025-05-27 7:20 ` [PATCH v5 2/4] dt-bindings: PCI: qcom,pcie-sm8150: document qcs615 Ziyue Zhang
2025-06-05 16:19 ` Rob Herring (Arm)
2025-05-27 7:20 ` [PATCH v5 3/4] arm64: dts: qcom: qcs615: enable pcie Ziyue Zhang
2025-05-27 13:37 ` Konrad Dybcio
2025-06-17 16:29 ` Manivannan Sadhasivam
2025-06-18 6:30 ` Ziyue Zhang
2025-06-17 16:36 ` Manivannan Sadhasivam
2025-06-18 6:48 ` Ziyue Zhang
2025-05-27 7:20 ` [PATCH v5 4/4] arm64: dts: qcom: qcs615-ride: Enable PCIe interface Ziyue Zhang
2025-06-17 16:33 ` Manivannan Sadhasivam
2025-06-18 7:01 ` Ziyue Zhang [this message]
2025-06-17 10:34 ` [PATCH v5 0/4] pci: qcom: Add QCS615 PCIe support Ziyue Zhang
2025-06-17 16:23 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ba2ae0-50fd-4fbe-acc0-3e9f89a75049@quicinc.com \
--to=quic_ziyuzhan@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®