From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B1D8211276 for ; Fri, 28 Mar 2025 06:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743144224; cv=none; b=EYpmRywxTn2DHzHG10hfEIAQWg9EdD+D4Uqjq4pE/ryfxQqH06G08IqRc0TsGrsBptUI42X5Mgd+F+OjYZ6Ma+p5wshpviS+e9BenFeoAm5X+Zr/BKe5EzhtWn3LarGFCOPhxIN6DCdRGSO73icyjlYNEQkkvi3pCtRSS+lqkfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743144224; c=relaxed/simple; bh=KZU1QVdlLDYQxNOtwAVGWlXYq4oFsamljq4Mex89UFU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=JCdD9FpiHVrup1HXghq4gT3jA8s82qHvrrX74HCH++WjAHIfo+aghXYCW5D7MS5uh457MWQspR6EcgdnoJEGhxA9uacMqgxjmQdN+Y1/d+Xhm/i0mHrVGJ8t5PJah+QF4asfAEdXQ4laHlwf6oFmUPcjMDpah9yAiZ1EI75nWI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4ZP9qy4WcFzTgrJ; Fri, 28 Mar 2025 14:39:58 +0800 (CST) Received: from kwepemd500013.china.huawei.com (unknown [7.221.188.12]) by mail.maildlp.com (Postfix) with ESMTPS id 61E771400D1; Fri, 28 Mar 2025 14:43:38 +0800 (CST) Received: from [10.159.166.136] (10.159.166.136) by kwepemd500013.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 28 Mar 2025 14:43:37 +0800 Message-ID: <51bae617-cfc7-43f9-968e-5f2a3ad9af40@huawei.com> Date: Fri, 28 Mar 2025 14:43:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel To: Jani Nikula , , , , , , , , CC: , , , , , , , , References: <20250319032435.1119469-1-shiyongbang@huawei.com> <20250319032435.1119469-6-shiyongbang@huawei.com> <87frj8c9ol.fsf@intel.com> <87jz8ea6zq.fsf@intel.com> <8ee961ca-0d3c-487d-a672-82714ee56743@huawei.com> <875xjw87dm.fsf@intel.com> <87v7ru6bfk.fsf@intel.com> From: Yongbang Shi In-Reply-To: <87v7ru6bfk.fsf@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd500013.china.huawei.com (7.221.188.12) > On Thu, 27 Mar 2025, Yongbang Shi wrote: >> 在 2025/3/26 17:32, Jani Nikula 写道: >>> On Tue, 25 Mar 2025, Yongbang Shi wrote: >>>>> On Mon, 24 Mar 2025, Yongbang Shi wrote: >>>>>>> On Wed, 19 Mar 2025, Yongbang Shi wrote: >>>>>>>> From: Baihan Li >>>>>>>> >>>>>>>> Add registering drm_aux and use it to get connector edid with drm >>>>>>>> functions. Add ddc channel in connector initialization to put drm_aux >>>>>>>> in drm_connector. >>>>>>>> >>>>>>>> Signed-off-by: Baihan Li >>>>>>>> Signed-off-by: Yongbang Shi >>>>>>>> Reviewed-by: Dmitry Baryshkov >>>>>>>> --- >>>>>>>> ChangeLog: >>>>>>>> v6 -> v7: >>>>>>>> - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nikula >>>>>>> I don't understand this, and I did not suggest such a thing. >>>>>>> >>>>>>> BR, >>>>>>> Jani. >>>>>>> >>>>>> Hi Jani, >>>>>> >>>>>> Is the modification of v8 correct? >>>>> I never received that for whatever reason. >>>> Here's the link: https://lore.kernel.org/all/20250320101455.2538835-1-shiyongbang@huawei.com/ >>> Thanks. >>> >>> The EDID handling looks fine. >>> >>> AFAICT you leak dp->aux.name though. >>> >>> >>> BR, >>> Jani. >> Thanks for for reminding me, actually the dp->aux.name was written because I misunderstood what you meant in V7, >> and I deleted it in V8. > This is in the link you posted: > > + dp->aux.name = kasprintf(GFP_KERNEL, "HIBMC DRM dp aux"); > Hi Jani, I got it. I think I can change it to devm_kasprintf() in next bug fix patch, is that ok? > >> Thanks, >> Baihan. >> >>>