From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-114.mta0.migadu.com [91.218.175.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632C1492183 for ; Fri, 21 Aug 2026 14:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787322927; cv=none; b=ICpSTxUHWmNj6PaMnKOUW+qT0df9qePlBoZvIPDRSDSjnrKEH4tbG1W4/U+nl+BvM9Ss/C/QebEzRs/w9AbQ/e3GByhMFREFbYyX1upecKzbJt6Y+UiJED1C+HfkakhK6yS8U++KP/wa4OmEOTCj/BJF0PE1dT5ypwgc6chs+hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787322927; c=relaxed/simple; bh=bS7xtK3Y10mb7sXERGKBIW/BwuKG0NF2Ds5Nq9AAhMQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hqTc1gsG1Y1Ssx1oyi4rW4aQnk1Nc/ixPiLf/+ISLYbpGGU8Y4iWIjROn8Z3d+5LoT3+KExk0O76d6kH6M91e7pU4v8reyk7qP9KUZ0qa5ovNi9W4/2QWnFGhwIe1OqJfNQTOdWpot+JB4QkqTHBMee7ZZq8QA5AwZC5oVxAWgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com; spf=pass smtp.mailfrom=chenxiaosong.com; dkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com header.b=Y2kwRc5O; arc=none smtp.client-ip=91.218.175.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chenxiaosong.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com header.b="Y2kwRc5O" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=bS7xtK3Y10mb7sXERGKBIW/BwuKG0NF2Ds5Nq9AAhMQ=; c=simple/simple; d=chenxiaosong.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787322920; v=1; x=1787927720; b=Y2kwRc5OslCeyu5acexIBcMOnj61IYcpGlR9kRoLTnw1lyDhOj67hy8q0ksfJNYBWCO4LK46 AH2972ZJD6GbNyXGH6oCzrL07Gs/4A4fxkB2EAEk7VbANbX3mxVBFgJMNyJxJj8CZ2sMEUbPLIU VvYKJ5C82sV88c3pmVG84VWTZAjZ4+KgzAjtb4dDVoyRWnb0WHsSLmG2aCxvcwjw9Vb8UUNPORa jj7+NVnA/IvcswokydpApLYF9tOZWzUqv/0toJGcy3+7HiBIuqWtD/VAH4I8fQOIAbMJxOowdAH xXwe7+20zWEExDIFwFHJRdPoJ2jPDBBm3Y15URZzPVCiw== X-Envelope-To: linux-kernel@vger.kernel.org Received: from [192.168.0.104] (220.202.230.161) by smtp.migadu.com with ESMTPS id b2935cdeee3e02eb; Fri, 21 Aug 2026 14:35:02 +0000 X-Mizu-Trace-ID: b2935cdeee3e02eb X-Migadu-Flow: FLOW_OUT Message-ID: <51d4f1ec-381d-4566-a1c8-96fd03e3520d@chenxiaosong.com> Date: Fri, 21 Aug 2026 22:34:59 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ksmbd: zero the object ID before filling FS_OBJECT_ID_INFORMATION To: Aleksandr Khromov , linkinjeon@kernel.org, sfrench@samba.org Cc: senozhatsky@chromium.org, tom@talpey.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, rrv@amicon.ru References: <20260821135801.3790290-1-haa@amicon.ru> From: ChenXiaoSong In-Reply-To: <20260821135801.3790290-1-haa@amicon.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Should we clear `info`? Will `info->extended_info.version_string` also leak? ``` 7437 case FS_OBJECT_ID_INFORMATION: 7438 { 7439 struct object_id_info *info; 7440 7441 info = (struct object_id_info *)(rsp->Buffer); ... 7454 memcpy(info->extended_info.version_string, "1.1.0", strlen("1.1.0")); 7455 rsp->OutputBufferLength = cpu_to_le32(64); ... 7458 } ``` On 8/21/2026 9:58 PM, Aleksandr Khromov wrote: > --- a/fs/smb/server/smb2pdu.c > +++ b/fs/smb/server/smb2pdu.c > @@ -6093,6 +6093,7 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, > > info = (struct object_id_info *)(rsp->Buffer); > > + memset(info->objid, 0, sizeof(info->objid)); > if (path.mnt->mnt_sb->s_uuid_len == 16) > memcpy(info->objid, path.mnt->mnt_sb->s_uuid.b, > path.mnt->mnt_sb->s_uuid_len); -- ChenXiaoSong Chinese Homepage: https://chenxiaosong.com English Homepage: https://chenxiaosong.com/en