From: Marek Vasut <marek.vasut@mailbox.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Peng Fan <peng.fan@oss.nxp.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
E Shattow <e@freeshell.de>
Subject: Re: [PATCH v1] dts: arm64: freescale: move imx9*-clock.h imx9*-power.h into dt-bindings
Date: Mon, 1 Sep 2025 12:30:51 +0200 [thread overview]
Message-ID: <51daddc4-1b86-4688-98cb-ef0f041d4126@mailbox.org> (raw)
In-Reply-To: <05f7d69a-9c05-4b47-ab04-594c37e975eb@kernel.org>
On 9/1/25 5:33 AM, Krzysztof Kozlowski wrote:
> On 01/09/2025 04:22, Marek Vasut wrote:
>> On 9/1/25 5:22 AM, Peng Fan wrote:
>>> On Sun, Aug 31, 2025 at 01:04:45PM -0700, E Shattow wrote:
>>>> Move imx9*-{clock,power}.h headers into
>>>> include/dt-bindings/{clock,power}/ and fix up the DTs
>>>
>>> No. The files should be under arch/arm64/boot/dts/freescale/
>> Why ? Linux already has include/dt-bindings/clock/ and
>> include/dt-bindings/power directories for exactly those headers , why
>> did iMX9 suddenly start conflating them into arch/arm64/boot/dts/freescale ?
>
>
> Because maybe these are not bindings?
Please compare arch/arm64/boot/dts/freescale/imx95-clock.h and
include/dt-bindings/clock/imx8mp-clock.h and clarify to me, why the
imx95-clock.h is not bindings and the imx8mp-clock.h is bindings.
Both files list clock IDs for the clock nodes, one clock one is SCMI
clock (iMX95), the other clock node is CCM clock (iMX8MP), and they are
both (SCMI and CCM) clock nodes in DT. Both header files may have to be
included in drivers, the iMX8MP headers already are, the iMX95 headers
currently are included only in U-Boot drivers.
I really don't see the difference here, sorry.
> Regardless whether you agree or
> not, the commit should clearly explain the reason behind.
Which commit ?
next prev parent reply other threads:[~2025-09-01 10:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 20:04 E Shattow
2025-09-01 3:22 ` Peng Fan
2025-09-01 2:22 ` Marek Vasut
2025-09-01 3:33 ` Krzysztof Kozlowski
2025-09-01 6:09 ` Peng Fan
2025-09-01 10:30 ` Marek Vasut [this message]
2025-09-01 10:54 ` Krzysztof Kozlowski
2025-09-01 11:07 ` E Shattow
2025-09-01 12:15 ` Krzysztof Kozlowski
2025-09-01 23:32 ` Marek Vasut
2025-09-04 9:34 ` Peng Fan
2025-09-08 23:39 ` Marek Vasut
2025-09-10 7:07 ` Peng Fan
2025-10-02 5:27 ` E Shattow
2025-11-02 17:42 ` Marek Vasut
2025-09-01 3:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51daddc4-1b86-4688-98cb-ef0f041d4126@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=e@freeshell.de \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®