Re: [PATCH] ASoC: dt-bindings: wlf,wm8994: Convert to dtschema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

On 08/02/2023 18:39, Mark Brown wrote:
> On Wed, Feb 08, 2023 at 06:25:52PM +0100, Krzysztof Kozlowski wrote:
>> Convert the Wolfson WM1811/WM8994/WM8958 audio codecs bindings to DT
>> schema.
> 
>> Changes against original binding:
>> 1. Add missing LDO1VDD-supply for WM1811.
> 
> Both LDOs are present on all variants.

The schematics for Arndale with WM1811 and WM1811 datasheet I found in
internet say there is only LDO1VDD pin, thus "both" does not look
correct at least for wm1811.

But if you meant that this should be for WM8994 as well, then sure, I
can change it.

> 
>> 2. Use "gpios" suffix for wlf,ldo1ena and wlf,ldo2ena (Linux kernel's
>>    gpiolib already looks for both variants).
>> 3. Do not require AVDD1-supply and DCVDD-supply, because at least on
>>    Arndale board with Exynos5250 these are grounded.
> 
> Are you *sure* they are grounded and not supplied from the LDOs?

That's what I have on schematics (attached), if I got it right.

Best regards,
Krzysztof

[-- Attachment #2: Schematics_Arndale_Audio_WM1811A-A.pdf --]
[-- Type: application/pdf, Size: 43386 bytes --]