From: Qais Yousef <qyousef@layalina.io>
To: John Stultz <jstultz@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Christian Loehle <christian.loehle@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Wei Wang <wvw@google.com>
Subject: Re: [PATCH v3 1/2] sched/uclamp: Fix race condition leading to imbalanced uclamp_rq
Date: Thu, 29 Oct 2026 12:51:30 +0000 [thread overview]
Message-ID: <51eadc2c-e4e5-4f64-b1f2-87f2620969b8@layalina.io> (raw)
In-Reply-To: <CANDhNCqe6qSfCFvXy5qT62uKO23cBPXt6yBbTQtBUDJE0RPBVQ@mail.gmail.com>
On 10/28/26 17:18, John Stultz wrote:
> On Tue, Oct 27, 2026 at 7:05 PM Qais Yousef <qyousef@layalina.io> wrote:
>>
>> Static keys are not guaranteed to be enabled atomically across CPUs.
>
> Nit: Not only across CPUs, but also across jump_label callsites! I
> believe the enqueue/dequeue race Wei reported happened on the same
> cpu.
>
> thanks
> -john
Right, this is news to me. I'll update the text. Thanks!
next prev parent reply other threads:[~2026-10-29 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 2:05 [PATCH v3 0/2] Fix uclamp race against non atomic static key enable Qais Yousef
2026-10-28 2:05 ` [PATCH v3 1/2] sched/uclamp: Fix race condition leading to imbalanced uclamp_rq Qais Yousef
2026-10-28 10:53 ` Peter Zijlstra
2026-10-28 11:12 ` Qais Yousef
2026-10-28 11:13 ` Christian Loehle
2026-10-28 12:09 ` Qais Yousef
2026-10-29 12:57 ` Qais Yousef
2026-10-28 17:18 ` John Stultz
2026-10-29 12:51 ` Qais Yousef [this message]
2026-10-28 2:05 ` [PATCH v3 2/2] sched/uclamp: Use wrappers instead of open coding UCLAMP_FLAG_IDLE Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51eadc2c-e4e5-4f64-b1f2-87f2620969b8@layalina.io \
--to=qyousef@layalina.io \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®