From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Viswanath Boma <quic_vboma@quicinc.com>,
video.upstream.external@qti.qualcomm.com,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Dikshita Agarwal <dikshita@codeaurora.org>
Subject: Re: [PATCH 5/7] venus : Addition of support for VIDIOC_TRY_ENCODER_CMD
Date: Tue, 26 Jul 2022 13:05:50 +0300 [thread overview]
Message-ID: <51eb6fd9-928f-bd97-d603-e9096402c799@linaro.org> (raw)
In-Reply-To: <20220712122347.6781-5-quic_vboma@quicinc.com>
On 7/12/22 15:23, Viswanath Boma wrote:
> From: Dikshita Agarwal <dikshita@codeaurora.org>
>
> v4l2 compliance expecting support for vidioc_try_encoder_cmd
> error details : test VIDIOC_(TRY_)ENCODER_CMD: FAIL
>
> Change-Id: I87a655dc506f3e713e2c86ab5203ca9c45cc5e1b
Drop Change-Id and add Dikshita's Signed-off tag.
> Signed-off-by: Viswanath Boma <quic_vboma@quicinc.com>
> ---
> drivers/media/platform/qcom/venus/venc.c | 1 +
> 1 file changed, 1 insertion(+)
With above comments fixed you can add my:
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 30ddb84c24997..4f10f5de7e3e6 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -589,6 +589,7 @@ static const struct v4l2_ioctl_ops venc_ioctl_ops = {
> .vidioc_subscribe_event = venc_subscribe_event,
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> .vidioc_encoder_cmd = venc_encoder_cmd,
> + .vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
> };
>
> static int venc_pm_get(struct venus_inst *inst)
--
regards,
Stan
next prev parent reply other threads:[~2022-07-26 10:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 12:23 [PATCH 1/7] venus : Add default values for the control V4L2_CID_COLORIMETRY_HDR10_MASTERING_DISPLAY Viswanath Boma
2022-07-12 12:23 ` [PATCH 2/7] venus : Addition of control support - V4L2_CID_MIN_BUFFERS_FOR_OUTPUT Viswanath Boma
2022-07-25 10:37 ` Stanimir Varbanov
2022-07-12 12:23 ` [PATCH 3/7] venus : CAPTURE Plane width/height alignment with OUT plane Viswanath Boma
2022-07-12 12:23 ` [PATCH 4/7] venus : Addition of EOS Event support for Encoder Viswanath Boma
2022-07-25 10:44 ` Stanimir Varbanov
2022-07-12 12:23 ` [PATCH 5/7] venus : Addition of support for VIDIOC_TRY_ENCODER_CMD Viswanath Boma
2022-07-26 10:05 ` Stanimir Varbanov [this message]
2022-07-12 12:23 ` [PATCH 6/7] venus : Remove the capture plane settings for venc_g_parm/venc_s_parm Viswanath Boma
2022-07-12 12:23 ` [PATCH 7/7] venus : Allow MIN/MAX settings for the v4l2 encoder controls defined range Viswanath Boma
2022-07-25 10:41 ` Stanimir Varbanov
2022-07-12 12:35 ` [PATCH 1/7] venus : Add default values for the control V4L2_CID_COLORIMETRY_HDR10_MASTERING_DISPLAY Manivannan Sadhasivam
2022-07-18 10:31 ` Viswanath Boma (Temp)
2022-07-12 13:34 ` Nicolas Dufresne
2022-07-18 10:35 ` Viswanath Boma (Temp)
2022-07-25 9:01 ` Stanimir Varbanov
2022-07-25 9:07 ` Stanimir Varbanov
2022-08-08 9:28 ` [PATCH V2 0/7] Fixes for Encoder Compliance issues quic_vboma
2022-08-08 9:28 ` [PATCH V2 1/7] venus : Add default values for the control quic_vboma
2022-08-08 9:28 ` [PATCH V2 2/7] venus : Addition of control support - V4L2_CID_MIN_BUFFERS_FOR_OUTPUT quic_vboma
2022-08-08 9:28 ` [PATCH V2 3/7] venus : CAPTURE Plane width/height alignment with OUT plane quic_vboma
2022-08-08 9:28 ` [PATCH V2 4/7] venus : Addition of EOS Event support for Encoder quic_vboma
2022-08-08 9:28 ` [PATCH V2 5/7] venus : Addition of support for VIDIOC_TRY_ENCODER_CMD quic_vboma
2022-08-08 9:28 ` [PATCH V2 6/7] venus : Remove the capture plane settings for venc_g_parm/venc_s_parm quic_vboma
2022-08-30 13:30 ` Stanimir Varbanov
2022-08-08 9:28 ` [PATCH V2 7/7] venus : Allow MIN/MAX settings for the v4l2 encoder controls defined range quic_vboma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51eb6fd9-928f-bd97-d603-e9096402c799@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vboma@quicinc.com \
--cc=video.upstream.external@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®