From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kory Maincent <kory.maincent@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Daniel Stone <daniels@collabora.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Mark Yacoub <markyacoub@google.com>,
Sean Paul <seanpaul@google.com>,
Manasi Navare <navaremanasi@google.com>,
Drew Davenport <ddavenport@google.com>,
Louis Chauvet <louis.chauvet@bootlin.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Kory Maincent <kory.maincent@bootlin.com>
Subject: Re: [PATCH RFC v3 0/8] Add support for DisplayPort link training information report
Date: Mon, 16 Nov 2026 15:10:30 +0200 [thread overview]
Message-ID: <51ec15feef9a88e460ab6fefc48b5b982f4857c0@intel.com> (raw)
In-Reply-To: <20261012-feat_link_cap-v3-0-7517f4aba0f3@bootlin.com>
On Mon, 12 Oct 2026, Kory Maincent <kory.maincent@bootlin.com> wrote:
> DisplayPort link training negotiates the physical-layer parameters needed
> for a reliable connection: lane count, link rate, and optionally Display
> Stream Compression (DSC). Currently, each driver exposes this state in
> its own way, often through driver-specific debugfs entries, with no
> standard interface for userspace diagnostic and monitoring tools.
>
> This series introduces generic helpers, for exposing DP link capabilities
> and state as standard sysfs entries.
So how did we end up with sysfs here?
> The aim of such development is to guide users to select the most suitable
> DisplayPort connector for their needs. For example, if you have a USB-C
> hub with lesser capabilities than your computer’s native DisplayPort
> connector (such as HBR2 versus HBR3 support), the system could recommend
> connecting high-resolution displays directly to the computer’s port
> instead of through the hub to ensure optimal performance.
I do wonder how all this is supposed to work in more complex real world
scenarios, though.
I believe the user primarily cares about *modes*. Which display modes
can be used with each display/connector pair.
With the low level link information, are you proposing to compute the
required bandwidth for modes in userspace? I think it's going to be a
lot of work to compute the bandwidth requirements, taking into account
DP SST vs. MST vs. UHBR and DSC and bit depth and everything, and you'll
still miss any driver/GPU specific contraints. Or are you just proposing
to match the physical characteristics only?
Given all the connectors and displays and their modes on a system, you
could estimate a) for each display, what modes could be used on each
connector, and b) for each connector, what modes could be used on a
display, if connected. From the user POV, they could be shown why some
display mode is not available on the current connector, and crucially,
on which connector it could be available.
In general, I'm wondering if you're really after higher level
information, something like "connector max available bandwidth
with/without DSC", that would more directly map to the user needs as I
see them than low level link details.
Do you have the userspace somewhere? That's needed for merging UABI
anyway [1].
[1] https://docs.kernel.org/gpu/drm-uapi.html#open-source-userspace-requirements
>
> The new drm_dp_source_set_caps and drm_dp_sink_set_caps helper expose
> source and sink training capabilities to userspace via sysfs attributes
> under dp_link. Finally drm_dp_set_cur_link_params helper is provided to
> report current link information at runtime.
>
> Three drivers are updated as reference implementations: i915 (direct
> connector path), ANX7625 and MediaTek (via the bridge connector framework
> using a new DRM_BRIDGE_OP_DP flag).
>
> Here is a sysfs example:
>
> cur_link_info_dsc sink_link_caps_nlanes
> cur_link_info_link_rate source_link_caps_dsc
> cur_link_info_nlanes source_link_caps_link_rates
> sink_link_caps_dsc source_link_caps_nlanes
> sink_link_caps_link_rates
>
> 1620000 2160000 2700000 3240000 4320000 5400000
>
> 1620000 2700000 5400000 10000000 20000000
>
> 5400000
>
> This series is rebased on top of drm-misc and may conflict with the
> current state of the drm i915 tree. Which tree should pick this up,
> given that it mixes core development with driver changes?
For development, please just base your work on top of drm-tip, and the
tree(s) will be sorted out later.
BR,
Jani.
> Patch 1,2: Move helpers out of i915
> Patch 3: Introduce DisplayPort link training capabilities and state helpers
> Patch 4: Read i915 DSC capabilities in any case
> Patch 5 Use dp_connector helpers in i915 to expose link training state
> Patch 6: Introduce DRM_BRIDGE_OP_DP and wire bridge connectors
> Patch 7: Use dp_connector helpers in anx7625 to expose link training state
> Patch 8: Use dp_connector helpers in mediatek to expose link training state
>
> Changes in v3:
> - Rework the core to use new helpers instead of an extension of
> drmm_connector_init().
> - Add a new mutex to protect sysfs read write access instead of using
> the global connection_mutex.
> - Move helpers out of i915.
> - Add the support in the anx7625 driver.
> - Link to v2: https://patch.msgid.link/20260619-feat_link_cap-v2-0-a3dec4c02ad9@bootlin.com
>
> Changes in v2:
> - Removed work converting i915 to DRM managed resource
> - Remove voltage swing and pre-emphasis properties
> - Expose link training state via sysfs dp_link/ group instead of
> connector properties
> - Add comprehensive sysfs attributes for both source and sink capabilities
> - Add new helpers for managing sink capabilities and for current link
> parameters
> - Link to v1: https://lore.kernel.org/r/20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Kory Maincent (8):
> drm: Move sink link rates reading helpers out of i915
> drm: Move DSC capability reading helper out of i915
> drm: Introduce DisplayPort link training capabilities and state helpers
> drm/i915/display/dp: Read DPCD DSC capabilities in any case
> drm/i915/display/dp: Use dp_connector helpers to expose link training state
> drm/bridge: Expose link training state via new DRM_BRIDGE_OP_DP flag
> drm/analogix/anx7625: Use dp_connector helpers to expose link training state
> drm/mediatek: Use dp_connector helpers to expose link training state
>
> Documentation/ABI/testing/sysfs-class-drm-dp | 85 +++
> drivers/gpu/drm/bridge/analogix/anx7625.c | 68 +++
> drivers/gpu/drm/bridge/analogix/anx7625.h | 1 +
> drivers/gpu/drm/display/Kconfig | 1 +
> drivers/gpu/drm/display/drm_bridge_connector.c | 29 ++
> drivers/gpu/drm/display/drm_dp_helper.c | 571 +++++++++++++++++++++
> drivers/gpu/drm/drm_connector.c | 11 +
> drivers/gpu/drm/drm_sysfs.c | 155 ++++++
> drivers/gpu/drm/i915/display/intel_display_types.h | 2 +
> drivers/gpu/drm/i915/display/intel_dp.c | 249 ++++-----
> .../gpu/drm/i915/display/intel_dp_link_training.c | 14 +
> drivers/gpu/drm/mediatek/mtk_dp.c | 79 ++-
> include/drm/display/drm_dp.h | 1 +
> include/drm/display/drm_dp_helper.h | 25 +
> include/drm/drm_bridge.h | 13 +
> include/drm/drm_connector.h | 53 ++
> include/drm/drm_sysfs.h | 1 +
> 17 files changed, 1202 insertions(+), 156 deletions(-)
> ---
> base-commit: 34e9ab0182494d7599dc9759bc216550d814b396
> change-id: 20260226-feat_link_cap-20cbb6f31d40
>
> Best regards,
> --
> Köry Maincent, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>
--
Jani Nikula, Intel
prev parent reply other threads:[~2026-11-16 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 15:10 Kory Maincent
2026-10-12 15:10 ` [PATCH RFC v3 1/8] drm: Move sink link rates reading helpers out of i915 Kory Maincent
2026-11-16 11:58 ` Jani Nikula
2026-10-12 15:10 ` [PATCH RFC v3 2/8] drm: Move DSC capability reading helper " Kory Maincent
2026-11-16 12:03 ` Jani Nikula
2026-10-12 15:10 ` [PATCH RFC v3 3/8] drm: Introduce DisplayPort link training capabilities and state helpers Kory Maincent
2026-10-12 15:10 ` [PATCH RFC v3 4/8] drm/i915/display/dp: Read DPCD DSC capabilities in any case Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 5/8] drm/i915/display/dp: Use dp_connector helpers to expose link training state Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 6/8] drm/bridge: Expose link training state via new DRM_BRIDGE_OP_DP flag Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 7/8] drm/analogix/anx7625: Use dp_connector helpers to expose link training state Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 8/8] drm/mediatek: " Kory Maincent
2026-11-10 9:14 ` CK Hu (胡俊光)
2026-11-16 13:10 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ec15feef9a88e460ab6fefc48b5b982f4857c0@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniels@collabora.com \
--cc=ddavenport@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.chauvet@bootlin.com \
--cc=luca.ceresoli@bootlin.com \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyacoub@google.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=navaremanasi@google.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@google.com \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®