From: Robert Hancock <hancockrwd@gmail.com>
To: "Jung-Ik (John) Lee" <jilee@google.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Daniel Walker <dwalker@fifo99.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Grant Grundler <grundler@google.com>,
Gwendal Grignou <gwendal@google.com>,
Eric Uhrhane <ericu@google.com>
Subject: Re: [PATCH] libata: Add pata_atp867x driver for Artop/Acard ATP867X controllers
Date: Sat, 12 Sep 2009 23:50:45 -0600 [thread overview]
Message-ID: <51f3faa70909122250o59fcd174ifee4277ba25a20fe@mail.gmail.com> (raw)
In-Reply-To: <8b5805ff0909122155u77a869c5t89a81fbf1a7eb391@mail.gmail.com>
On Sat, Sep 12, 2009 at 10:55 PM, Jung-Ik (John) Lee <jilee@google.com> wrote:
> I agree in that it's hard to measure/signify the additional overhead,
> since those io insts are already too slow.
> Anyways, the two extra "if"s and one PIO_MASK on every ioread/iowrite
> are pure overhead on top of in/out insts.
I don't think that any platform currently breaks if you use the
readX/writeX instead of ioreadX/iowriteX on iomapped MMIO addresses
(and there's certainly enough code in libata that does this), but the
API definition really expects that you should be using ioread/iowrite
so it would probably be best not to add any more of these..
next prev parent reply other threads:[~2009-09-13 5:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 2:06 Jung-Ik (John) Lee
2009-09-12 2:14 ` Daniel Walker
2009-09-12 10:59 ` Jung-Ik (John) Lee
2009-09-12 16:49 ` Robert Hancock
2009-09-13 0:17 ` Jung-Ik (John) Lee
2009-09-13 0:26 ` Jung-Ik (John) Lee
2009-09-13 0:31 ` Jeff Garzik
2009-09-13 0:37 ` Jung-Ik (John) Lee
2009-09-13 0:55 ` Jeff Garzik
2009-09-13 2:41 ` Jung-Ik (John) Lee
2009-09-13 3:12 ` Jeff Garzik
2009-09-13 4:55 ` Jung-Ik (John) Lee
2009-09-13 5:50 ` Robert Hancock [this message]
2009-09-15 4:32 ` Jung-Ik (John) Lee
2009-09-17 20:51 ` Jeff Garzik
2009-09-13 0:38 ` Jeff Garzik
2009-09-13 0:50 ` Jung-Ik (John) Lee
2009-09-15 0:38 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f3faa70909122250o59fcd174ifee4277ba25a20fe@mail.gmail.com \
--to=hancockrwd@gmail.com \
--cc=dwalker@fifo99.com \
--cc=ericu@google.com \
--cc=grundler@google.com \
--cc=gwendal@google.com \
--cc=jgarzik@pobox.com \
--cc=jilee@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®