From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514C0226863; Fri, 25 Jul 2025 14:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753455314; cv=none; b=EyTQ6KS3Ug7J7/9IO+9YEeyJFLsFHLj14Ke+8WSRubtfBnzVKeviqn3jyKidaPCJWHAjlVj0fsNf+6Sy4C2joyc2OXoa9ZaTIdai+k0Jx/WIDm6GCjU7skUtwP8vZ+QU5mv60j6r6+BMXAcMhPSTx33Mu0Z5wH4ulzB50ngkJpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753455314; c=relaxed/simple; bh=EXHaox/1NzXqFsnH0dWanvrMBp8w7U0rZ5dj8B4pNPs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=InSoyrUa+8xiXZYeviXV59bQ39qXUGHijD+nBaGttbiBa/b+4vx/63mzWm7Sd2h5/vMQaqgzHIG5cgFvei2bVlvgAcNQu7J6u1KTWoTuc6gEDAxQ8T77mqT9kShqEteFLpVI4/Askh6VMhMzdsuF08OqznBtsVCdxi5rb0DAHsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=m0jj0ZKW; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="m0jj0ZKW" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56PCJhSE009250; Fri, 25 Jul 2025 16:54:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= EXHaox/1NzXqFsnH0dWanvrMBp8w7U0rZ5dj8B4pNPs=; b=m0jj0ZKW2V09n25s 7B7U6M9MLZjvJcMWRYlZu2uFMoeeao9xbmKHMjp231wc1Gp9uJ4HcC8UklLPBTGC HTWTXgbC6XqRFU8qn68Fxm/2C7mfOYEEjoH3L0nmPMqHWADv7AcbyNsZ/tX/SrEH rQYs6bVDHl96QbwVaQLnkbATyLJrUKGt9anHUzsXgc2IeJzY+j7wo02hNDcoPKm3 DSB5xGyi/yp2TLyA1KfNMc05VQx0e+AlozREVTRbbUAGcAD0asReA0mUXre8LULM XpTEtFaY8nJDqkhkeuyD2rbNFwh+uIwH1OJVtVHmyep5WVEsmMDd18//lFI0E8QJ 8Y4cGg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 483w3j3kdk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Jul 2025 16:54:48 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id D000040044; Fri, 25 Jul 2025 16:53:23 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id EC96979F3AB; Fri, 25 Jul 2025 16:52:16 +0200 (CEST) Received: from [10.252.19.90] (10.252.19.90) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Jul 2025 16:52:15 +0200 Message-ID: <51f9e2bd-1129-4a82-b12a-72663e57ebda@foss.st.com> Date: Fri, 25 Jul 2025 16:52:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Linux-stm32] [PATCH 09/12] arm64: dts: st: add lvds support on stm32mp255 To: Clement LE GOFFIC , Yannick Fertre , Philippe Cornu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Catalin Marinas , Will Deacon , Christophe Roullier CC: , , , , References: <20250725-drm-misc-next-v1-0-a59848e62cf9@foss.st.com> <20250725-drm-misc-next-v1-9-a59848e62cf9@foss.st.com> <85673db7-d311-47cc-be52-291d94e136e4@foss.st.com> Content-Language: en-US From: Raphael Gallais-Pou In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-25_04,2025-07-24_01,2025-03-28_01 On 7/25/25 13:13, Clement LE GOFFIC wrote: > On 7/25/25 13:08, Clement LE GOFFIC wrote: >> Hi Raphael, >> >> On 7/25/25 12:04, Raphael Gallais-Pou wrote: >>> The LVDS is used on STM32MP2 as a display interface. >>> >>> Add the LVDS node. >>> >>> Signed-off-by: Raphael Gallais-Pou >>> --- >>>   arch/arm64/boot/dts/st/stm32mp255.dtsi | 12 ++++++++++++ >>>   1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/st/stm32mp255.dtsi b/arch/arm64/boot/ >>> dts/st/stm32mp255.dtsi >>> index >>> f689b47c5010033120146cf1954d6624c0270045..a4d965f785fa42c4597494010855aec7e1b9fdd1 >>> 100644 >>> --- a/arch/arm64/boot/dts/st/stm32mp255.dtsi >>> +++ b/arch/arm64/boot/dts/st/stm32mp255.dtsi >>> @@ -6,6 +6,18 @@ >>>   #include "stm32mp253.dtsi" >>>   &rifsc { >>> +    lvds: lvds@48060000 { >>> +        compatible = "st,stm32mp25-lvds"; >> >> For the compatible you now need one comaptible per SoC. >> It means your compatible should look like : "st,stm32mp251-lvds". >> This way, if on the 253 or 255 there is an issue you are able to easily add >> match data in the driver with compatible "st,stm32mp253-lvds" or >> "st,stm32mp255-lvds". >> A prior discussion on this subject has been raised on my V1 of HDP involving >> Krzysztof and Alexandre : >> https://lore.kernel.org/all/418a80a9-8c08-4dd1- bf49-1bd7378321aa@kernel.org/ > Woops, this comment should target the add of the ltdc compatible as I see that > lvds one already exists and can't be changed. > Though the main idea is here. Indeed, the compatible is wrong. After carefully reading the thread you point to, I suggest the following: * Rename the new LTDC compatible to "st,stm32mp251-ltdc" * Add another compatible for the LVDS. So it would have "st,stm32mp255-lvds", and falls back to "st,stm32mp25-lvds". Like so the LVDS driver would not have to be modified. Alex, Krzysztof, does that seem good to you ? Best regards, Raphaël > >> >>> +        #clock-cells = <0>; >>> +        reg = <0x48060000 0x2000>; >>> +        clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>; >>> +        clock-names = "pclk", "ref"; >>> +        resets = <&rcc LVDS_R>; >>> +        access-controllers = <&rifsc 84>; >>> +        power-domains = <&CLUSTER_PD>; >>> +        status = "disabled"; >>> +    }; >>> + >>>       vdec: vdec@480d0000 { >>>           compatible = "st,stm32mp25-vdec"; >>>           reg = <0x480d0000 0x3c8>; >>> >> >> Best regards, >> Clément >