mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: "Marc-Olivier Champagne"
	<marc-olivier.champagne@savoirfairelinux.com>,
	"Jessica Zhang" <jesszhan0024@gmail.com>,
	"Guido Günther" <agx@sigxcpu.org>
Cc: Ondrej Jirman <megi@xff.cz>, Purism Kernel Team <kernel@puri.sm>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
	Felix Boucher <felix.boucher@savoirfairelinux.com>,
	Quentin Lehoux <quentin.lehoux@savoirfairelinux.com>
Subject: Re: [PATCH 1/4] drm/panel: st7703: set prepare_prev_first
Date: Thu, 8 Oct 2026 10:24:08 +0200	[thread overview]
Message-ID: <51fec579-a74a-4bfd-8b5d-2e7308405211@linaro.org> (raw)
In-Reply-To: <20261007201859.3709656-2-marc-olivier.champagne@savoirfairelinux.com>

On 10/7/26 22:18, Marc-Olivier Champagne wrote:
> The DSI host must be enabled for the panel to be initialized in
> prepare(). Set the prepare_prev_first flag to guarantee this.
> 
> Suggested-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Signed-off-by: Marc-Olivier Champagne <marc-olivier.champagne@savoirfairelinux.com>
> ---
>   drivers/gpu/drm/panel/panel-sitronix-st7703.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index 70f7282471e6..368c57591817 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -973,6 +973,8 @@ static int st7703_probe(struct mipi_dsi_device *dsi)
>   	if (ret < 0)
>   		return dev_err_probe(&dsi->dev, ret, "Failed to get orientation\n");
>   
> +	ctx->panel.prepare_prev_first = true;
> +
>   	ret = drm_panel_of_backlight(&ctx->panel);
>   	if (ret)
>   		return ret;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

  reply	other threads:[~2026-10-08  8:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 20:18 [PATCH 0/4] drm/panel: st7703: add support for DCLTek DT300248 Marc-Olivier Champagne
2026-10-07 20:18 ` [PATCH 1/4] drm/panel: st7703: set prepare_prev_first Marc-Olivier Champagne
2026-10-08  8:24   ` Neil Armstrong [this message]
2026-10-07 20:18 ` [PATCH 2/4] drm/panel: st7703: move init commands to prepare() Marc-Olivier Champagne
2026-10-08  8:24   ` Neil Armstrong
2026-10-07 20:18 ` [PATCH 3/4] dt-bindings: display: panel: add compatible for DCLTek 300248 10.25in panel Marc-Olivier Champagne
2026-10-08  7:30   ` Conor Dooley
2026-10-08  7:36   ` Conor Dooley
2026-10-07 20:18 ` [PATCH 4/4] drm/panel: st7703: Add DCLTek 300248 10.25in display Marc-Olivier Champagne
2026-10-08  8:25   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51fec579-a74a-4bfd-8b5d-2e7308405211@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agx@sigxcpu.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felix.boucher@savoirfairelinux.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jerome.oufella@savoirfairelinux.com \
    --cc=jesszhan0024@gmail.com \
    --cc=kernel@puri.sm \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marc-olivier.champagne@savoirfairelinux.com \
    --cc=megi@xff.cz \
    --cc=mripard@kernel.org \
    --cc=quentin.lehoux@savoirfairelinux.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®