From: "H. Peter Anvin" <hpa@zytor.com>
To: Linn Crosetto <linn@hp.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
yinghai@kernel.org, penberg@kernel.org, jacob.shin@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: selective remapping in parse_setup_data()
Date: Mon, 12 Aug 2013 14:08:34 -0700 [thread overview]
Message-ID: <52094ED2.1000308@zytor.com> (raw)
In-Reply-To: <1376341206-72835-1-git-send-email-linn@hp.com>
On 08/12/2013 02:00 PM, Linn Crosetto wrote:
> PCI devices may advertise a ROM size larger than early_memremap() is
> able to handle. If this occurs it leads to a NULL dereference in
> parse_setup_data(). Avoid this by remapping the data only when
> necessary.
>
> Signed-off-by: Linn Crosetto <linn@hp.com>
I think you need to clarify the various subcases (the code looks right,
but the explanation needs to be improved.)
-hpa
next prev parent reply other threads:[~2013-08-12 21:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 21:00 Linn Crosetto
2013-08-12 21:08 ` H. Peter Anvin [this message]
2013-08-12 23:01 ` [PATCH v2] " Linn Crosetto
2013-08-12 23:30 ` Yinghai Lu
2013-08-13 21:46 ` [PATCH v3] x86: avoid remapping data " Linn Crosetto
2013-08-13 22:22 ` Yinghai Lu
2013-08-14 6:26 ` Pekka Enberg
2013-09-01 11:40 ` [tip:x86/mm] " tip-bot for Linn Crosetto
2013-09-01 23:15 ` [PATCH v3] " H. Peter Anvin
2013-09-06 18:06 ` [PATCH 0/3] x86/mm: fix early_memremap() sparse warnings Linn Crosetto
2013-09-06 18:06 ` [PATCH 1/3] x86/mm: fix sparse warnings from early_memremap() Linn Crosetto
2013-09-06 18:06 ` [PATCH 2/3] x86: fix sparse warning in parse_e820_ext() Linn Crosetto
2013-09-06 18:06 ` [PATCH 3/3] x86: fix early_iounmap() sparse warnings in setup.c Linn Crosetto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52094ED2.1000308@zytor.com \
--to=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=linn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome