From: Stephen Warren <swarren@wwwdotorg.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: bcousson@baylibre.com, tony@atomide.com,
myungjoo.ham@samsung.com, cw00.choi@samsung.com,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net,
george.cherian@ti.com, gregkh@linuxfoundation.org,
linux-doc@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
balbi@ti.com
Subject: Re: [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*
Date: Fri, 16 Aug 2013 16:21:10 -0600 [thread overview]
Message-ID: <520EA5D6.3040409@wwwdotorg.org> (raw)
In-Reply-To: <1376648448-27447-1-git-send-email-kishon@ti.com>
On 08/16/2013 04:20 AM, Kishon Vijay Abraham I wrote:
> The Palmas device contains only a USB VID detector, so modified the
> compatible type to *ti,palmas-usb-vid*.
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
> PALMAS USB COMPARATOR
> Required Properties:
> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
> + - compatible : Should be "ti,palmas-usb-vid".
Has the old value been published in a release kernel? If so, it makes
sense to document both values, but say the old one is deprecated, and ...
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> static struct of_device_id of_palmas_match_tbl[] = {
> - { .compatible = "ti,palmas-usb", },
> - { .compatible = "ti,twl6035-usb", },
> + { .compatible = "ti,palmas-usb-vid", },
... perhaps just add the new value here, and don't remove the old values?
If not, ignore this.
next prev parent reply other threads:[~2013-08-16 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 10:20 Kishon Vijay Abraham I
2013-08-16 22:21 ` Stephen Warren [this message]
2013-08-19 5:05 ` Kishon Vijay Abraham I
2013-08-19 8:33 ` Chanwoo Choi
2013-08-19 8:47 ` Kishon Vijay Abraham I
2013-08-19 9:24 ` Chanwoo Choi
2013-08-19 9:29 ` Kishon Vijay Abraham I
2013-08-19 10:21 ` Benoit Cousson
2013-08-19 10:26 ` Kishon Vijay Abraham I
2013-08-19 16:11 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520EA5D6.3040409@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome