From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbcI1Lzc (ORCPT ); Wed, 28 Sep 2016 07:55:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbcI1LzW (ORCPT ); Wed, 28 Sep 2016 07:55:22 -0400 Subject: Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection To: "Wu, Feng" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" References: <1475011213-34225-1-git-send-email-pbonzini@redhat.com> <1475011213-34225-3-git-send-email-pbonzini@redhat.com> <0ff6ce09-c890-ca41-6863-d72262c5a65b@redhat.com> Cc: "yang.zhang.wz@gmail.com" , "mst@redhat.com" , "rkrcmar@redhat.com" From: Paolo Bonzini Message-ID: <520afc01-7936-0d41-6d45-67bd88e7475b@redhat.com> Date: Wed, 28 Sep 2016 13:55:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 28 Sep 2016 11:55:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2016 13:53, Wu, Feng wrote: >> > - update_cr8_intercept is disabled if APICv, see vmx.c: >> > >> > if (enable_apicv) >> > kvm_x86_ops->update_cr8_intercept = NULL; > Which tree are you using, I am using linux kernel tree with Linux 4.8-rc7, > and I only see the following code in vmx.c > > if(!cpu_has_vmx_tpr_shadow()) > kvm_x86_ops->update_cr8_intercept = NULL; You're right, it was an older tree. On the other hand, 4.8-rc7 has this in update_cr8_intercept: if (vcpu->arch.apicv_active) return; :) Paolo