mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Kacur <jkacur@gmail.com>
To: Sven-Thorsten Dietrich <sdietrich@novell.com>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RT] Fix build errors in rtmutex
Date: Thu, 13 Aug 2009 13:04:57 +0200	[thread overview]
Message-ID: <520f0cf10908130404p86c991k85dcd797e7e21baa@mail.gmail.com> (raw)
In-Reply-To: <1250138467.15796.16.camel@quadrophenia.thebigcorporation.com>

On Thu, Aug 13, 2009 at 6:41 AM, Sven-Thorsten
Dietrich<sdietrich@novell.com> wrote:
> Subject: Fix up "too few parameters to function" build errors in rtmutex
> From: Sven-Thorsten Dietrich <sdietrich@suse.de>
>
> Signed-off-by: Sven-Thorsten Dietrich <sdietrich@suse.de>
> Index: b/kernel/rtmutex.c
> ===================================================================
> --- a/kernel/rtmutex.c
> +++ b/kernel/rtmutex.c
> @@ -1513,7 +1513,8 @@ int rt_mutex_start_proxy_lock(struct rt_
>
>        mark_rt_mutex_waiters(lock);
>
> -       if (!rt_mutex_owner(lock) || try_to_steal_lock(lock, task)) {
> +       if (!rt_mutex_owner(lock) ||
> +          try_to_steal_lock(lock, task, STEAL_NORMAL)) {
>                /* We got the lock for task. */
>                debug_rt_mutex_lock(lock);
>                rt_mutex_set_owner(lock, task, 0);
> @@ -1522,7 +1523,8 @@ int rt_mutex_start_proxy_lock(struct rt_
>                return 1;
>        }
>
> -       ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock);
> +       ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock,
> +                                    flags);
>
>        if (ret && !waiter->task) {
>                /*
> Index: b/kernel/trace/ring_buffer.c
> ===================================================================
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -2522,7 +2522,7 @@ ring_buffer_peek(struct ring_buffer *buf
>        if (event && event->type_len == RINGBUF_TYPE_PADDING)
>                rb_advance_reader(cpu_buffer);
>        if (dolock)
> -               atomic_)spin_unlock(&cpu_buffer->reader_lock);
> +               atomic_spin_unlock(&cpu_buffer->reader_lock);
>        local_irq_restore(flags);
>
>        if (event && event->type_len == RINGBUF_TYPE_PADDING) {
>
>

Hi Sven

I have to admit I'm scratching my head over this one, I don't see any
rt trees that it applies to. Which version are you referring to here?

Thanks

      reply	other threads:[~2009-08-13 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13  4:41 Sven-Thorsten Dietrich
2009-08-13 11:04 ` John Kacur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520f0cf10908130404p86c991k85dcd797e7e21baa@mail.gmail.com \
    --to=jkacur@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=sdietrich@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®