From: John Kacur <jkacur@redhat.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
"Steven Rostedt" <srostedt@redhat.com>,
linux-kbuild@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: dont hardcode path to lsmod
Date: Tue, 19 Jan 2010 18:42:13 +0100 [thread overview]
Message-ID: <520f0cf11001190942n2c765618m8a66b8afe82010d0@mail.gmail.com> (raw)
In-Reply-To: <8bd0f97a1001190923p6104acb4if5ec7225d549b713@mail.gmail.com>
On Tue, Jan 19, 2010 at 6:23 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Tue, Jan 19, 2010 at 09:25, Américo Wang wrote:
>> On Tue, Jan 19, 2010 at 01:52:00AM -0500, Mike Frysinger wrote:
>>>The lsmod utility has always been installed into /bin with the newer
>>>module-init-tools package, so let lsmod be found via PATH instead of
>>>hardcoding the old modutils /sbin path.
>>>
>>
>> Some distro doesn't set /sbin to PATH, so for me a better solution
>> would be making PATH contain /sbin, and then use "lsmod".
>
> read my changelog -- module-init-tools has always installed into /bin.
> so what your distro does with /sbin doesnt matter.
> -mike
> --
I prefer my patches work for the real-world instead of the "so what
your distro does doesn't matter" world.
next prev parent reply other threads:[~2010-01-19 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 6:52 Mike Frysinger
2010-01-19 14:10 ` Steven Rostedt
2010-01-19 14:25 ` Américo Wang
[not found] ` <520f0cf11001190822t6d3221bco20739d586608bfde@mail.gmail.com>
2010-01-19 16:29 ` John Kacur
2010-01-19 16:37 ` Steven Rostedt
2010-01-19 17:37 ` John Kacur
2010-01-19 17:23 ` Mike Frysinger
2010-01-19 17:38 ` Steven Rostedt
2010-01-19 17:42 ` John Kacur [this message]
2010-01-19 17:54 ` Mike Frysinger
2010-01-19 18:12 ` John Kacur
2010-01-19 19:18 ` Mike Frysinger
2010-01-20 3:16 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520f0cf11001190942n2c765618m8a66b8afe82010d0@mail.gmail.com \
--to=jkacur@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srostedt@redhat.com \
--cc=vapier.adi@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®