From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933095AbcBYOtJ (ORCPT ); Thu, 25 Feb 2016 09:49:09 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:15098 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760599AbcBYOtG convert rfc822-to-8bit (ORCPT ); Thu, 25 Feb 2016 09:49:06 -0500 From: Amitkumar Karwar To: Marcel Holtmann CC: BlueZ development , Nishant Sarmukadam , "linux-kernel@vger.kernel.org" , Cathy Luo , Ganapathi Bhat Subject: RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Topic: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Index: AQHRa7W9CVyXd2Ca9UCxy6Qr7P32M5883ydQ Date: Thu, 25 Feb 2016 14:49:02 +0000 Message-ID: <5214f565d5754440ade286fc6b83f859@SC-EXCH04.marvell.com> References: <1455627233-6928-1-git-send-email-akarwar@marvell.com> <273F0F9E-5E5C-4F21-A503-027A83B7F61E@holtmann.org> In-Reply-To: <273F0F9E-5E5C-4F21-A503-027A83B7F61E@holtmann.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-02-25_05:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1602250214 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marcel, > From: Marcel Holtmann [mailto:marcel@holtmann.org] > Sent: Saturday, February 20, 2016 1:37 PM > To: Amitkumar Karwar > Cc: BlueZ development; Nishant Sarmukadam; linux-kernel@vger.kernel.org; > Cathy Luo; Ganapathi Bhat > Subject: Re: [PATCH v2] Bluetooth: hci_uart: Support firmware download > for Marvell > > Hi Amitkumar, > > > This patch implement firmware download feature for Marvell Bluetooth > > devices. If firmware is already downloaded, it will skip downloading. > > > > Signed-off-by: Ganapathi Bhat > > Signed-off-by: Amitkumar Karwar > > --- > > v2: Fixed compilation warning reported by kbuild test robot > > --- Thanks for your review. We are able to resolve all your comments. We are now checking how can we avoid firmware and helper file name global variables and module parameters. Regards, Amitkumar