From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B4EEB64DC for ; Mon, 17 Jul 2023 06:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbjGQGhU (ORCPT ); Mon, 17 Jul 2023 02:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbjGQGhP (ORCPT ); Mon, 17 Jul 2023 02:37:15 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7D8593; Sun, 16 Jul 2023 23:37:14 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36H5pcVl028723; Mon, 17 Jul 2023 06:36:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=DgQvj7P9SKd+4vVK23Z5kicrESGlyfKetsdyqYrWP4Y=; b=b8rr18dkArFi7/ETMxqT7NPoGdT+zplC+bCgdTHt6cDy0drRRFo2WQkwZqng6CtUYYM0 w3T8EFpMbiiISJUecaqAlBYNbKuuyL7upDDI/RHlkEXUYzD0SDwrLRpLpYRgbZHG5h4N pJ9M8exepJKDuwTikXOemA1z+VnxvUL1UYCO+U3Lt5hns91TKMxCFuhyZY5vpYccfy06 Kk8UAUvqd+SW1n+9BY3toWTA+z7adw6vhprGHrido+hEPcQ6m69vH9NHjz7kZrSY82z4 leEcaMjHjXj0+wDg2TmRRAsbL+hgbG8fzKJrGXLONMpGARYKJfo3dyN0QlrujAX76eNc 8w== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3run0cak6r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 06:36:45 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36H6ahvk004461 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 06:36:43 GMT Received: from [10.216.50.105] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Sun, 16 Jul 2023 23:36:36 -0700 Message-ID: <52156f94-5bb0-93af-52ed-7cbb14492393@quicinc.com> Date: Mon, 17 Jul 2023 12:06:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/6] clk: qcom: Add NSS clock Controller driver for IPQ9574 Content-Language: en-US To: Simon Horman CC: , , , , , , , , , , , , , , , , , , , , , , , References: <20230711093529.18355-1-quic_devipriy@quicinc.com> <20230711093529.18355-5-quic_devipriy@quicinc.com> From: Devi Priya In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: kQYvtwfe5s0BgfS4IKtY760RPTpIrRUJ X-Proofpoint-ORIG-GUID: kQYvtwfe5s0BgfS4IKtY760RPTpIrRUJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_05,2023-07-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=909 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307170059 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/2023 11:07 AM, Simon Horman wrote: > On Tue, Jul 11, 2023 at 03:05:27PM +0530, Devi Priya wrote: >> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based >> devices. >> >> Signed-off-by: Devi Priya > > ... > >> +static const struct qcom_reset_map nss_cc_ipq9574_resets[] = { >> + [NSS_CC_CE_BCR] = { 0x28400, 0 }, >> + [NSS_CC_CLC_BCR] = { 0x28600, 0 }, >> + [NSS_CC_EIP197_BCR] = { 0x16004, 0 }, >> + [NSS_CC_HAQ_BCR] = { 0x28300, 0 }, >> + [NSS_CC_IMEM_BCR] = { 0xe004, 0 }, >> + [NSS_CC_MAC_BCR] = { 0x28100, 0 }, >> + [NSS_CC_PPE_BCR] = { 0x28200, 0 }, >> + [NSS_CC_UBI_BCR] = { 0x28700, 0 }, >> + [NSS_CC_UNIPHY_BCR] = { 0x28900, 0 }, >> + [UBI3_CLKRST_CLAMP_ENABLE] = { 0x28A04, 9 }, >> + [UBI3_CORE_CLAMP_ENABLE] = { 0x28A04, 8 }, >> + [UBI2_CLKRST_CLAMP_ENABLE] = { 0x28A04, 7 }, >> + [UBI2_CORE_CLAMP_ENABLE] = { 0x28A04, 6 }, >> + [UBI1_CLKRST_CLAMP_ENABLE] = { 0x28A04, 5 }, >> + [UBI1_CORE_CLAMP_ENABLE] = { 0x28A04, 4 }, >> + [UBI0_CLKRST_CLAMP_ENABLE] = { 0x28A04, 3 }, >> + [UBI0_CORE_CLAMP_ENABLE] = { 0x28A04, 2 }, >> + [NSSNOC_NSS_CSR_ARES] = { 0x28A04, 1 }, >> + [NSS_CSR_ARES] { 0x28A04, 0 }, > > Hi Devi, > > There appears to be an '=' missing in the line above. Hi Simon, Thanks for catching it! will update it in V2. Regards, Devi Priya > > ...