mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "joe@perches.com" <joe@perches.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dynamic debug: line queries failing due to uninitialized local variable
Date: Wed, 28 Aug 2013 10:53:40 -0400	[thread overview]
Message-ID: <521E0EF4.7090102@akamai.com> (raw)
In-Reply-To: <20130827174136.GG21564@kroah.com>

On 08/27/2013 01:41 PM, Greg KH wrote:
> On Tue, Aug 27, 2013 at 04:50:03PM +0000, jbaron@akamai.com wrote:
>> Settings of the form, 'line x module y +p', can fail arbitrarily due to an
>> uninitialized local variable. With this patch results are consistent, as
>> expected.
>>
>> Signed-off-by: Jason Baron <jbaron@akamai.com>
>> ---
>>  lib/dynamic_debug.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> How far back should this patch go for older kernels?  Is this a bug that
> people are hitting today and causing problems, or is it only a 3.11-rc
> issue?
>
> thanks,
>
> greg k-h

Looks like this was introduced in >= 3.3. So its been there for quite a
while. Its a bit of a corner case, since it requires, 'line' to be
specified before anything else. It depends on on how you order your query.

I found the bug via code inspection - no bug reports that I'm aware of.
So I wouldn't think this is an urgent fix.

Thanks,

-Jason


      reply	other threads:[~2013-08-28 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 16:50 jbaron
2013-08-27 17:41 ` Greg KH
2013-08-28 14:53   ` Jason Baron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521E0EF4.7090102@akamai.com \
    --to=jbaron@akamai.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome