Re: [PATCH v8 27/28] media: iris: enable video driver probe of SM8250 SoC

[Dikshita Agarwal <quic_dikshita@quicinc.com>]

On 12/11/2024 2:17 PM, Dmitry Baryshkov wrote:
> On Wed, Dec 11, 2024 at 11:54:09AM +0530, Dikshita Agarwal wrote:
>>
>>
>> On 12/10/2024 9:53 PM, Stefan Schmidt wrote:
>>> hello Dikshita,
>>>
>>> On Tue, 10 Dec 2024 at 12:08, Dikshita Agarwal
>>> <quic_dikshita@quicinc.com> wrote:
>>>>
>>>> Initialize the platform data and enable video driver probe of SM8250
>>>> SoC. Add a kernel param to select between venus and iris drivers for
>>>> platforms supported by both drivers, for ex: SM8250.
>>>>
>>>> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
>>>
>>> [...]
>>>
>>>> --- a/drivers/media/platform/qcom/iris/iris_ctrls.c
>>>> +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c
>>>> @@ -17,6 +17,8 @@ static inline bool iris_valid_cap_id(enum platform_inst_fw_cap_type cap_id)
>>>>  static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id)
>>>>  {
>>>>         switch (id) {
>>>> +       case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:
>>>> +               return DEBLOCK;
>>>>         case V4L2_CID_MPEG_VIDEO_H264_PROFILE:
>>>>                 return PROFILE;
>>>>         case V4L2_CID_MPEG_VIDEO_H264_LEVEL:
>>>> @@ -32,6 +34,8 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id)
>>>>                 return 0;
>>>>
>>>>         switch (cap_id) {
>>>> +       case DEBLOCK:
>>>> +               return V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER;
>>>>         case PROFILE:
>>>
>>> The handling for DEBLOCK does not seem to be part of the SM8250
>>> enablement. Or did I miss something?
>>> It seems they should be part of a different patch that makes use of
>>> the DEBLOCK cap.
>>>
>> this cap is part of platform caps of SM8250 and the value(set by
>> client/default) of this will set to firmware as part of start streaming
>> through set APIs.
> 
> Then it still makes sense to split into two parts: one for DEBLOCK
> handling, one for the platform data only. Or you can safely merge
> DEBLOCK into the main caps commit.
I am just adding the platform caps for SM8250 and mapping between cap id
and corresponding v4l2 id in this patch.
Handling of all these caps are already part of main commit.

> 
>> {
>> +		.cap_id = DEBLOCK,
>> +		.min = 0,
>> +		.max = 1,
>> +		.step_or_mask = 1,
>> +		.value = 0,
>> +		.hfi_id = HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER,
>> +		.set = iris_set_u32,
>> +	},
>>
>> Thanks,
>> Dikshita
>>> regards
>>> Stefan Schmidt
>