From: Ahmet Sezgin Duran <ahmet@sezginduran.net>
To: Siddhesh Sable <ixebec777@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: fix CamelCase variable name Bpp to bpp
Date: Thu, 11 Jun 2026 13:54:06 +0300 [thread overview]
Message-ID: <52292e15-0f8d-4b71-bbc8-c4e5040a39fc@sezginduran.net> (raw)
In-Reply-To: <20260611103748.29584-1-ixebec777@gmail.com>
On 6/11/26 1:37 PM, Siddhesh Sable wrote:
> CamelCase variable names violate the kernel coding style guidelines.
> Rename all occurrences of 'Bpp' to 'bpp' to fix checkpatch warnings.
>
> Signed-off-by: Siddhesh Sable <ixebec777@gmail.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
Still not okay. You need to:
* Send a new revision as V2,V3,V4,etc for changes and describe them.
* Wait at least a day to send a new revision.
* Make sure that your patch actually applies. Currently it doesn't apply
to Greg's latest staging-testing branch.
Even better, have a look at Dan Carpenter's blog post about this:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Regards,
Ahmet Sezgin Duran
next prev parent reply other threads:[~2026-06-11 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:37 Siddhesh Sable
2026-06-11 10:54 ` Ahmet Sezgin Duran [this message]
2026-06-11 12:22 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-06-11 10:20 Xebec77
2026-06-11 10:31 ` Ahmet Sezgin Duran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52292e15-0f8d-4b71-bbc8-c4e5040a39fc@sezginduran.net \
--to=ahmet@sezginduran.net \
--cc=gregkh@linuxfoundation.org \
--cc=ixebec777@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®