mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>,
	Michal Simek <michal.simek@xilinx.com>
Cc: LKML <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Laura Abbott <lauraa@codeaurora.org>,
	Olof Johansson <olof@lixom.net>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules
Date: Tue, 2 Dec 2014 10:36:28 +0100	[thread overview]
Message-ID: <522b42cef4da41d48e81d99bc8e447a8@BL2FFO11FD047.protection.gbl> (raw)
In-Reply-To: <CA+V-a8vw2d8H=Qx99M4oXqUatt5wmePVW82ARdMcWLEVLXbZJw@mail.gmail.com>

On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
> Hi Michal,
> 
> Thanks for the patch.
> 
> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Modules can use this function for creating pool.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> I am pushing Zynq OCMC driver which is using this function.
>>
>> ---
>>  lib/genalloc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
> don’t you need to add an entry in include/linux/genalloc.h ?

Not sure what exactly you mean. declaration is there.
include/linux/genalloc.h:120:extern struct gen_pool *devm_gen_pool_create(struct device *dev,

And all EXPORT_SYMBOL() are out of headers directly below function
which you want to export.

Can you please clarify what you did mean by that?

Thanks,
Michal

  reply	other threads:[~2014-12-02  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 13:00 Michal Simek
2014-12-02  9:31 ` Prabhakar Lad
2014-12-02  9:36   ` Michal Simek [this message]
2014-12-02  9:42     ` Prabhakar Lad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522b42cef4da41d48e81d99bc8e447a8@BL2FFO11FD047.protection.gbl \
    --to=michal.simek@xilinx.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=lauraa@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=olof@lixom.net \
    --cc=prabhakar.csengg@gmail.com \
    --cc=vladimir_zapolskiy@mentor.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®