From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3A654F81 for ; Thu, 25 Sep 2025 19:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758828699; cv=none; b=WcOcp3vIcS8MVqQGwKXybc1MmIiactXy6xeq/e74F12lZl7hhcCV69Y1fNJPhwmd/8sGgd90gOiR0UHGvSjS+jZgfpit7G3GwkWHnYyojLC34qJQ1rw/ileRVvZa0ld5PbBiWcsk8qISSROa9FjiDK0KbfOnUs2rENC6vpp35mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758828699; c=relaxed/simple; bh=ixD4JAeSZTT+cKIC7yfTKECAN5O4rsWfV2NLw5qppKk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LLeGkwuw+iZSqVhl2l3HQXWksokfeZ+DipZKy39ymWyiFMv6vl09wr5qk+mRgvKpPxFcpJ1bZz5yr+YC+vUQJA4FNpcsG1aGRDsNHYphnQCga4OllW/FUH84fO2SjGT1m999KZkvlgdKXKNwXLwaImW8Yn7QiLCiF8EAeXErl+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iSZjTMmu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iSZjTMmu" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58PIPoPi000861 for ; Thu, 25 Sep 2025 19:31:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xN2zeve8MKIwluD+p5R+V0hgYRPi/KXOcVTKAzLg/4s=; b=iSZjTMmumnhjkPd5 idAoiZHRPTjI2FP0FOQ52Z+3uS6MgotKPSeJyOGdAP2yM6uNAs2rTOKEi1Bv4v7K JCRnkRuegx1kKEul6YCLMgIOyaWcZS12eIAyVpBTnzaQGx/OwuVK72JRvwLXeLME k66Nd3Iv+m596//tSsmMEFgSdmnjvpojgoTd3EW+usDAkmk6hsaylR0L8KpoeP8O JC91/Hx+ZtVZMjZBxQJOHHV4hi6HrwmgTSD/GoxrQp09WIUqsa3WQWHjLf9d7Fus QQ2vYY7bQN9vVb2SHPbkOcSgRsv/yTL+BpO6VOFrOvnnuN1fjhP8Y8hTBJxtB+Z2 qos38w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0tr4y5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 25 Sep 2025 19:31:36 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-32e09eaf85dso1785663a91.1 for ; Thu, 25 Sep 2025 12:31:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758828695; x=1759433495; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xN2zeve8MKIwluD+p5R+V0hgYRPi/KXOcVTKAzLg/4s=; b=Cr/GfwGl/LFcrbqrjoslOb5Kh2YeKtNWpLbpv7B6fD6W7mlVT9zCp9Lw/7ymTTb0kb mbHFg2++G3RRTvHHSscvT+1PhPC8Q+eZDi/SApd89OhARI/YTYhHqncJ+BNkoBWxTdj6 62lFh1SwsyNxFZcwFWuOgKuCHA9aPjODCWbDCcxxXDvFbr4QCoQxn08jOcF5VxcpjCqh qe6il30QrCAK0cDrYY28JPdhY3lbv+bjVSywdOlVdtwA0sGTUkHC6PjAYDL1NU57y4Q7 xoLwUZtFDpseCpcft6XVpEDdmiUeAMwZeU1TuxO8+npewo8JwIx3oAMyZ3yCKJS/7GII m5kQ== X-Forwarded-Encrypted: i=1; AJvYcCW6Nrn2C9jAxfU5BbFFpta2Aw7RDZO1reXl/KYdc3cvbpX/gz6bywO1ufTMFldcGrkQ38X6gzCpyq75ebQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxZIramt8HbV4WiCZuM+3gM3e/cFF7qsMooHvOrOmNvwLOd0XjX gnI+WtdRE42kWd3Y0Ns8xlTgYVGnwcMziWrilb2uCgWMZ0DjrCp5kOfGeXXMDdBdUrrZKC14ilq rR1c68m9zlkjjz4vcBk6L2gMYYe+wrkKUhktp2xXiLKWPt6sg3XmOwnyMsQGca89nrFg= X-Gm-Gg: ASbGncv4nj0+/7sZaFt5p1yzIxCbTwZLFhycUGEqR/DqhcatMuI63X3e1SaDuqYvB6/ Mg/kjE3MFznvKH5EiUbEknMqwrus6/U/B22Y63DZiQO7rPinUtjzWlU2Nc9jL21HYHj/3dutdH/ VauRFWOTCKDh+hqkYJlpXoJkI9o27lzMk1nXpjWXBaEkXOiVL5Xvaghnn5o+XX+TlHcW+FKroRG 6INWZpx3rGGOhoveRgHHMkBRO5c4nY01ASfewXu0QN7SgsmnTgRj748LyS3JifrBf8sH7W2n1U2 AVDmoMUkoCtk8id9Xsegu/w3niYV3EzVPiutz1MZqL0Ndmf2COCSkZ/ZlsqGrG2/FwQrnmTkYRE = X-Received: by 2002:a17:90b:5109:b0:32b:baaa:21b0 with SMTP id 98e67ed59e1d1-3342a2498b0mr5055280a91.6.1758828695553; Thu, 25 Sep 2025 12:31:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcihAr9QeDqmHNipkjhQZA1yhGxUL+6BzxOO9aN0JoSkA8hWKZHTY3tt89U22izY99lHd9JQ== X-Received: by 2002:a17:90b:5109:b0:32b:baaa:21b0 with SMTP id 98e67ed59e1d1-3342a2498b0mr5055254a91.6.1758828695141; Thu, 25 Sep 2025 12:31:35 -0700 (PDT) Received: from [192.168.0.166] ([49.205.248.165]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3341be3a010sm6552860a91.28.2025.09.25.12.31.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 12:31:34 -0700 (PDT) Message-ID: <522d7244-0003-a42e-9be0-1d353df8d5bd@oss.qualcomm.com> Date: Fri, 26 Sep 2025 01:01:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding Content-Language: en-US To: Dmitry Baryshkov Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20250925-knp_video-v1-0-e323c0b3c0cd@oss.qualcomm.com> <20250925-knp_video-v1-1-e323c0b3c0cd@oss.qualcomm.com> From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I9Vohdgg c=1 sm=1 tr=0 ts=68d59898 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=AkZwv1uTgJSVxlfcUQlFCg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gEfo2CItAAAA:8 a=eVofJsru2PQPkhUZkREA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-GUID: o6bQZGel6BslzzbN7WamwMrycbJm07s8 X-Proofpoint-ORIG-GUID: o6bQZGel6BslzzbN7WamwMrycbJm07s8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfX3DCWaaiaOCXv Cejtoje+fqCSVzMzWnyARGx+qcoE1Ukg3CuVtftrQ+yeqaCFgfEGcBRW4bBjmTAqZlmnyuGL2TQ Ck9zCPbdAP4fh9LW9JkROlzR6TWxaa1qT5rxvCGgsqaa5leYE69x6EmuKqML9vB5BovtwZZ7TNG BBut70YmFNSR3qtq3PGVk/JiQDoU0Hwf2C0+umTLWAb6g70R30vEneLW8PqN0tBFjy7+/jwQEjb vnKzin8QJ1MCsfFxRcqWTelA1dt2WrHirFjWO01lDD797xn1KTSrISiESGrl3dUcUbvg2tmSDZ/ 8JdjW8uRioG4EGLPPw2CdmCESvoQbapx9MTTqzK3YbiWRV3Fogganenbo3eDiYj+fbwAZVlKezy /mtgsX8+N1Z/6QlKJr0ydX+geuvSiA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-25_01,2025-09-25_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 On 9/26/2025 12:55 AM, Dmitry Baryshkov wrote: > On Thu, Sep 25, 2025 at 04:44:39AM +0530, Vikash Garodia wrote: >> Kaanapali SOC brings in the new generation of video IP i.e iris4. When >> compared to previous generation, iris3x, it has, >> - separate power domains for stream and pixel processing hardware blocks >> (bse and vpp). >> - additional power domain for apv codec. >> - power domains for individual pipes (VPPx). >> - different clocks and reset lines. >> >> There are variants of this hardware, where only a single VPP pipe would >> be functional (VPP0), and APV may not be present. In such case, the >> hardware can be enabled without those 2 related power doamins, and >> corresponding clocks. This explains the min entries for power domains >> and clocks. >> Iommus include all the different stream-ids which can be possibly >> generated by vpu4 video hardware in both secure and non secure >> execution mode. >> >> This patch depends on following patches >> https://lore.kernel.org/all/20250924-knp-interconnect-v1-1-4c822a72141c@oss.qualcomm.com/ >> https://lore.kernel.org/all/20250924-knp-clk-v1-3-29b02b818782@oss.qualcomm.com/ >> >> Signed-off-by: Vikash Garodia >> --- >> .../bindings/media/qcom,kaanapali-iris.yaml | 236 +++++++++++++++++++++ >> 1 file changed, 236 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,kaanapali-iris.yaml b/Documentation/devicetree/bindings/media/qcom,kaanapali-iris.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..f3528d514fe29771227bee5f156962fedb1ea9cd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-iris.yaml >> @@ -0,0 +1,236 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/qcom,kaanapali-iris.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm kaanapali iris video encode and decode accelerators >> + >> +maintainers: >> + - Vikash Garodia >> + - Dikshita Agarwal >> + >> +description: >> + The iris video processing unit is a video encode and decode accelerator >> + present on Qualcomm platforms. >> + >> +properties: >> + compatible: >> + const: qcom,kaanapali-iris >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + power-domains: >> + minItems: 5 >> + maxItems: 7 > > You are sending bindings for a single device on a single platform. How > comes that it has min != max? I was planning to reuse this binding for the variant SOCs of kaanapali/vpu4. If we do not have min interface, then for those variants, we have to either have separate bindings or add if/else conditions(?). Introducing min now can make it easily usable for upcoming vpu4 variants. > >> + >> + power-domain-names: >> + items: >> + - const: venus >> + - const: vcodec0 >> + - const: vpp0 >> + - const: vpp1 >> + - const: apv >> + - const: mxc >> + - const: mmcx >> + >> + clocks: >> + minItems: 8 >> + maxItems: 10 > > And here. Same case here. > >> + >> + clock-names: >> + items: >> + - const: iface >> + - const: core >> + - const: vcodec0_core >> + - const: iface1 >> + - const: core_freerun >> + - const: vcodec0_core_freerun >> + - const: vcodec_bse >> + - const: vcodec_vpp0 >> + - const: vcodec_vpp1 >> + - const: vcodec_apv >> + >