From: Markus Elfring <Markus.Elfring@web.de>
To: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Maxime Ripard <mripard@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Scott Branden <sbranden@broadcom.com>,
Stefan Wahren <wahrenst@gmx.net>, Stephen Boyd <sboyd@kernel.org>,
Ray Jui <rjui@broadcom.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>
Subject: clk: bcm2835: Checking a clk_register() call in bcm2835_clk_probe()
Date: Fri, 18 Oct 2019 20:42:27 +0200 [thread overview]
Message-ID: <522fb1f3-d710-2f86-60b1-4224b8d3d17a@web.de> (raw)
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “bcm2835_clk_probe” contains still
an unchecked call of the member function “clk_register”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/bcm/clk-bcm2835.c?id=7571438a4868e7cb09d698ab52e54f9722020eef#n2243
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/bcm/clk-bcm2835.c#L2243
How do you think about to improve it?
* Which error code would you like to return for a failed
clock registration at this place?
* Will it be needed to delete any information about clocks
as exception handling?
Regards,
Markus
reply other threads:[~2019-10-18 18:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522fb1f3-d710-2f86-60b1-4224b8d3d17a@web.de \
--to=markus.elfring@web.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=emamd001@umn.edu \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mbrugger@suse.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=pakki001@umn.edu \
--cc=rjui@broadcom.com \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=smccaman@umn.edu \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®