From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80CC91FDA for ; Tue, 23 Jul 2024 01:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721699319; cv=none; b=OH4gS5Q5ID0r2Gw2VpWDKdQID34k+EkZxA//LeYFDuPZOKK7B0I1mlugSOFj+PXRumrwFJsjqcBLwvMdqi71VXHdxWZvgvevWpBSgmZ7X+Y+PIWeZoimUpQpZXIq+ZmOKBtNvCNoujWGdoXIMohWIoxIic36bDdt/Re32XVYunY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721699319; c=relaxed/simple; bh=DEDEjz0B+os2tcybqYWA2ambaROLeHMbi3NqYIE9Sj4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Tb7PeCEx2fMFVowbg+NP7NNejm+ZgSvEoQacl2IRal34sLCSZYYzBpn3HSFBOAPXYH/7CIDad7X34UWQLTtCpV5E6xQlEergiaJN5psYacvyoXJy1Rhim2LjnitE/Kau+Uj72lbOD8BQTJC5ZxieuI1spPYsjQ3bZ+dK6LJlnpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WSg480jxzzdjrt; Tue, 23 Jul 2024 09:46:48 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 8C90F18005F; Tue, 23 Jul 2024 09:48:34 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 23 Jul 2024 09:48:34 +0800 Message-ID: <5230d72e-81fa-4ef1-b386-90bd3b06bf0e@huawei.com> Date: Tue, 23 Jul 2024 09:48:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. Content-Language: en-US To: Zi Yan , Andrew Morton , CC: David Hildenbrand , "Huang, Ying" , Baolin Wang , References: <20240722172917.503370-1-ziy@nvidia.com> <20240722172917.503370-3-ziy@nvidia.com> From: Kefeng Wang In-Reply-To: <20240722172917.503370-3-ziy@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) On 2024/7/23 1:29, Zi Yan wrote: > memory tiering can be enabled/disabled at runtime and > sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check > it. In migrate_misplaced_folio(), the check is missing when > PGPROMOTE_SUCCESS is incremented. Add the missing check. > > Reported-by: Kefeng Wang > Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan Reviewed-by: Kefeng Wang > --- > mm/migrate.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index bdbb5bb04c91..b819809da470 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, > putback_movable_pages(&migratepages); > if (nr_succeeded) { > count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); > - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) > + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) > + && !node_is_toptier(folio_nid(folio)) > + && node_is_toptier(node)) > mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, > nr_succeeded); The should be in advance of patch2, and change above to use folio_has_cpupid() helper() too. > }