From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757739Ab3ILIPO (ORCPT ); Thu, 12 Sep 2013 04:15:14 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:46844 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753935Ab3ILIPL (ORCPT ); Thu, 12 Sep 2013 04:15:11 -0400 Message-ID: <52317721.9050407@linux.vnet.ibm.com> Date: Thu, 12 Sep 2013 13:41:13 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Viresh Kumar CC: rjw@sisk.pl, swarren@wwwdotorg.org, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] cpufreq: don't break string in print statements References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13091208-4790-0000-0000-00000A46AC35 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2013 10:55 AM, Viresh Kumar wrote: > As a rule its better not to break string (quoted inside "") in a print statement > even if it crosses 80 column boundary as that may introduce unwanted bugs and so > this patch rewrites one of the print statements.. > Ok, if that is the convention, then so be it. > Signed-off-by: Viresh Kumar Reviewed-by: Srivatsa S. Bhat Regards, Srivatsa S. Bhat > --- > drivers/cpufreq/cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 28477eb..31f7845 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1192,8 +1192,8 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, > unlock_policy_rwsem_write(cpu); > > if (!frozen) { > - pr_debug("%s: policy Kobject moved to cpu: %d " > - "from: %d\n",__func__, new_cpu, cpu); > + pr_debug("%s: policy Kobject moved to cpu: %d from: %d\n", > + __func__, new_cpu, cpu); > } > } > } >