From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Paul Chavent <Paul.Chavent@onera.fr>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
jhovold@gmail.com, fschaefer.oss@googlemail.com, jslaby@suse.cz,
max@suse.de, giometti@enneenne.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.
Date: Fri, 13 Sep 2013 23:08:09 +0400 [thread overview]
Message-ID: <52336299.6070508@cogentembedded.com> (raw)
In-Reply-To: <1379086513-2434-2-git-send-email-paul.chavent@onera.fr>
Hello.
On 09/13/2013 07:35 PM, Paul Chavent wrote:
> Signed-off-by: Paul Chavent <paul.chavent@onera.fr>
> ---
> drivers/usb/serial/ftdi_sio.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index c45f9c0..df66495 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1966,8 +1966,14 @@ static int ftdi_process_packet(struct usb_serial_port *port,
> port->icount.dsr++;
> if (diff_status & FTDI_RS0_RI)
> port->icount.rng++;
> - if (diff_status & FTDI_RS0_RLSD)
> + if (diff_status & FTDI_RS0_RLSD) {
> port->icount.dcd++;
> + struct tty_struct *tty = tty_port_tty_get(&port->port);
Don't mix declaration and code. And add an empty line between them please.
> + if (tty)
> + usb_serial_handle_dcd_change(port, tty,
> + status & FTDI_RS0_RLSD);
> + tty_kref_put(tty);
> + }
WBR, Sergei
next prev parent reply other threads:[~2013-09-13 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 15:35 [PATCH 0/3] Enable PPS reporting for USB serial devices V2 Paul Chavent
2013-09-13 15:35 ` [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver Paul Chavent
2013-09-13 15:47 ` Greg KH
2013-09-13 15:51 ` Johan Hovold
2013-09-13 19:08 ` Sergei Shtylyov [this message]
2013-09-13 15:35 ` [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler Paul Chavent
2013-09-13 15:47 ` Greg KH
2013-09-13 15:53 ` Johan Hovold
2013-09-13 17:12 ` Rodolfo Giometti
2013-09-13 19:12 ` Sergei Shtylyov
2013-09-13 15:35 ` [PATCH 3/3] USB : serial : pl2303 wake up after dcd status check Paul Chavent
2013-09-13 16:23 ` Johan Hovold
2013-09-13 16:22 ` Paul Chavent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52336299.6070508@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Paul.Chavent@onera.fr \
--cc=fschaefer.oss@googlemail.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=max@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome