From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932576AbdJ3Lo0 (ORCPT ); Mon, 30 Oct 2017 07:44:26 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:45328 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbdJ3LoY (ORCPT ); Mon, 30 Oct 2017 07:44:24 -0400 X-Google-Smtp-Source: ABhQp+TL81gqf6ilrNnsvw2YFx0ueBWK+AVt8MFAq1HBVXbumBwTk/pOEhEsD9qNDyNMpbaxqJ9m2w== Subject: Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup() To: Johan Hovold , "Bryan O'Donoghue" Cc: Kees Cook , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Alex Elder , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org References: <20171024144938.GA41224@beast> <55a6647a-8565-09e8-9f45-d9048c7dd916@linaro.org> <20171030113202.GB7223@localhost> <558a6d02-515e-9998-18cc-b9b77d2b1d63@nexus-software.ie> <20171030113819.GD7223@localhost> From: "Bryan O'Donoghue" Message-ID: <523e9618-e72e-72fa-3d98-062e687ca226@linaro.org> Date: Mon, 30 Oct 2017 11:44:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20171030113819.GD7223@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/10/17 11:38, Johan Hovold wrote: > On Mon, Oct 30, 2017 at 11:35:50AM +0000, Bryan O'Donoghue wrote: >> On 30/10/17 11:32, Johan Hovold wrote: >>> The right thing to do here is to respin your patch from last year which >>> converts the loopback driver to use the timeout handling in greybus >>> core. >> >> Actually I wasn't clear if you wanted to to that yourself aswell as the >> rest if it. >> >> But sure I can do that conversion, it's on my list. > > IIRC it was basically done. Just some odd locking that could now also be > removed. > > Thanks, > Johan > I think once Kees' change is applied to operation.c and we convert the async stuff to operation.c's callbacks there ought to be no use of timers, linked lists of operations. I'll probably need at least a day to look at that, so it'll be the weekend before I can really allocate time. --- bod