From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933168AbcFOVah (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 17:30:37 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:62638 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753614AbcFOVae (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 17:30:34 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Chaoming Li <chaoming_li@realsil.com.cn>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: use s8 instead of char
Date: Wed, 15 Jun 2016 23:25:13 +0200
Message-ID: <5245411.kmNEkqpVVS@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <wrfjbn32taxw.fsf@redhat.com>
References: <20160615210318.4130648-1-arnd@arndb.de> <wrfjbn32taxw.fsf@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:knmLFEH7BGoZYOZPJZO7oFxHxXEcfCKwxJp3jE+peQKxNOoPpSh
 m3uStnOGx/Oe97lGdeV+xzGEbZLdNFB2tAt5fdMaekDEK0A4hdmDGpS1pHBTg99s0S+WfP2
 BifUyVBEqPuxpCmvvuuGSI5FjRl/55aL88vQ6o1+oAzEHBoh4728FpEOGOlyBqxzkiadIwq
 vycc9iEh1T3HD5QT9Z37w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:X0sYVgDu5Uw=:g7Y2dINzPhu3wrpR2kn67O
 NqugcNaf/vWbFuNkv3NUeNB34LVT+PB0Xw/YhV0KkpvRc6I/LbU1gLOcWKYHALM0uShj9VBCA
 bJCM38BdTrragUir83u0xuA4tQmCISpE6uRF9ZZZCZ0x2S/5nMKcoqYtAL4AQNEdm0N7Ep7uD
 9YjrjK0XpnZIaxVF8jDZLM49oCHs99VkoQySkNA/RTPYDSgXvKgBoBK7e54Wmi0IZ9IeuF2Eb
 HOvtsvF8IPpkv0+/GMENrAR45aywjsr44zPHhAFpOAieQuuEIuoCI3YcKT0eDLUhKN0Vl7Q7y
 mthe6MGGFKVTHwb8d2ZVia8zwGRsLzPLsY5VdHtYhd6rtr1ZBHVgiiDoH4BnjhdMyQ6ISMqCF
 HZH+Rw+VLBKfJv7J9fMETpnv0XaV0o8J1J04VEXwy5NDevGFji3g6NIox+8DUKkNsX5zEtUf4
 1smLkoOfOe5IfDIVhD6qi6etqUfW+1cemMMX7zrwmrlkFBX/QjuyhTeklpU6PWW7NQZbcuUY+
 IbHsXUr0p6K1BSWmWdcNtLaP8WLdrxpJxeb6D8u/kXz/E9SlFuwIRAFtULj4wNPTEecOtEjIk
 OzFKuT8D1fMaRV2lMR8t6hpMKes2Or/YFliJenN89lQXxdDOC/oY1GL4rcfgzhxXmRo+FvBLe
 QHx/2zdd1SYheKSCqEp4YDcVuqGluCSF8FVMYLm1eF9KxkNQpAxXZOcybmwx1pZIvrGcxHA5U
 X1Q7k1/PcVx6yIMD
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote:
> 
> Arnd,
> 
> rtlwifi and rtl8xxxu are two distinct drivers managed by different
> people. I'd be really nice if you could split this into a per driver
> patch.
> 
> That said, the use of char in rtl8xxxu is all as a flag indicator, so I
> don't think the s/char/s8/ conversion is justified. I used char rather
> than ugly bool to reduce the size of the struct.

Makes sense, I'll resend without that change. If anything, the flag
should become u8, not s8 anyway.

	Arnd