From: Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>
To: T Makphaibulchoke <tmac@hp.com>,
tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
aswin@hp.com, aswin_proj@lists.hp.com
Subject: Re: [PATCH 2/2] fs/ext4/namei.c: reducing contention on s_orphan_lock mmutex
Date: Thu, 03 Oct 2013 02:31:51 -0600 [thread overview]
Message-ID: <524D2B77.7090006@hp.com> (raw)
In-Reply-To: <20131003020526.GA22501@gmail.com>
On 10/02/2013 08:05 PM, Zheng Liu wrote:
> Hello,
>
>> - if (!EXT4_SB(sb)->s_journal)
>> + if (ext4_sb->s_journal)
> ^^^^^^^^
> typo: !ext4_sb->s_journal
> I am not sure whether or not this will impact the result because when
> journal is enabled the inode will not be added into orphan list.
>
> Regards,
> - Zheng
>
Thanks Zheng for pointing out the problem. Will fix the problem and rerun the test.
Thanks,
Mak.
next prev parent reply other threads:[~2013-10-03 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 15:36 [PATCH 1/2] fs/ext4: adding and initalizing new members of ext4_inode_info and ext4_sb_info T Makphaibulchoke
2013-10-02 15:36 ` [PATCH 2/2] fs/ext4/namei.c: reducing contention on s_orphan_lock mmutex T Makphaibulchoke
2013-10-03 2:05 ` Zheng Liu
2013-10-03 8:31 ` Thavatchai Makphaibulchoke [this message]
2013-10-04 0:41 ` Andreas Dilger
2013-10-03 23:08 ` Thavatchai Makphaibulchoke
2013-10-04 0:37 ` [PATCH 1/2] fs/ext4: adding and initalizing new members of ext4_inode_info and ext4_sb_info Andreas Dilger
2013-10-03 23:14 ` Thavatchai Makphaibulchoke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524D2B77.7090006@hp.com \
--to=thavatchai.makpahibulchoke@hp.com \
--cc=adilger.kernel@dilger.ca \
--cc=aswin@hp.com \
--cc=aswin_proj@lists.hp.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tmac@hp.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome