Re: [PATCH] cifs: avoid mixing bool and le16

["Steve French" <smfrench@gmail.com>]

Seems like a cast to bool or an "if ...else" would be clearer than using !!
By the way I don't see this warning - is it a newer compiler warning?

On Wed, Jul 23, 2008 at 6:52 PM, Harvey Harrison
<harvey.harrison@gmail.com> wrote:
> fs/cifs/cifssmb.c:3917:13: warning: incorrect type in assignment (different base types)
> fs/cifs/cifssmb.c:3917:13:    expected bool [unsigned] [usertype] is_unicode
> fs/cifs/cifssmb.c:3917:13:    got restricted __le16
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
>  fs/cifs/cifssmb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index 4511b70..56f1a71 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -3914,7 +3914,7 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
>        bool is_unicode;
>        struct dfs_referral_level_3 *ref;
>
> -       is_unicode = pSMBr->hdr.Flags2 & SMBFLG2_UNICODE;
> +       is_unicode = !!(pSMBr->hdr.Flags2 & SMBFLG2_UNICODE);
>        *num_of_nodes = le16_to_cpu(pSMBr->NumberOfReferrals);
>
>        if (*num_of_nodes < 1) {
> --
> 1.5.6.4.570.g052e
>
>
>
>



-- 
Thanks,

Steve