From: Steve French <smfrench@gmail.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: Horst Reiterer <horst.reiterer@gmail.com>,
linux-cifs-client@lists.samba.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-cifs-client] Re: [PATCH] fs/cifs: send SMB_COM_FLUSH in cifs_fsync
Date: Sun, 22 Feb 2009 20:35:19 -0600 [thread overview]
Message-ID: <524f69650902221835x551da9f3yb6750f723f33b1d5@mail.gmail.com> (raw)
In-Reply-To: <20090222181052.36763a2d@tupile.poochiereds.net>
On Sun, Feb 22, 2009 at 8:10 PM, Jeff Layton <jlayton@redhat.com> wrote:
> On Sun, 22 Feb 2009 17:34:46 -0800
> Jeff Layton <jlayton@redhat.com> wrote:
>
>> On Sun, 22 Feb 2009 22:12:11 +0100 (CET)
>> Horst Reiterer <horst.reiterer@gmail.com> wrote:
>>
>> > On Sun, 22 Feb 2009, Steve French wrote:
>> > > Suggestions on what to call such a new mount option? How about
>> > > "nostrictfsync" ?
>> >
>> > Sound good, should be self-explanatory for Samba users and those familiar
>> > with the fsync concept.
>> >
>> > Horst.
>>
>> My suggestion would be to not add a new option until someone requests
>> it/complains about it. We already have a lot of unneeded/unused mount
>> options, and I think this will just be adding one to the pile.
>>
>> My $.02...
>>
>
> ...and to lend further strength to this argument, we're not doing this
> at close(), but rather at fsync(). posix is pretty clear about what's
> supposed to happen at fsync:
>
> "The fsync() function shall request that all data for the open file
> descriptor named by fildes is to be transferred to the storage device
> associated with the file described by fildes."
>
> ...if you don't want to take the performance penalty then don't use
> fsync(). If you're using fsync, then you care about data integrity
> and adding a mount option to disable it is rather pointless.
There is a lot of history here (especially in the man page of
smb.conf) on dumb things apps do in this area. I don't object to
allowing users to turn strict sync behavior off. There are some apps
who presumably consider getting data to the server (which we already
do in fsync) "stable enough" storage (clients are not battery backed
up, with redundant, highly available hardware as some servers are).
I agree that the default should be to write the data to the metal on
the server (even though this can be very, very expensive) for fsync
--
Thanks,
Steve
next prev parent reply other threads:[~2009-02-23 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 20:51 Horst Reiterer
2009-02-20 20:55 ` Steve French
2009-02-21 0:27 ` [linux-cifs-client] " Jeff Layton
2009-02-21 1:21 ` Steve French
2009-02-22 20:50 ` Horst Reiterer
2009-02-22 21:03 ` Steve French
2009-02-22 21:12 ` Horst Reiterer
2009-02-23 1:34 ` [linux-cifs-client] " Jeff Layton
2009-02-23 2:10 ` Jeff Layton
2009-02-23 2:35 ` Steve French [this message]
2009-02-23 4:07 ` Steve French
2009-02-23 16:33 ` [linux-cifs-client] " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524f69650902221835x551da9f3yb6750f723f33b1d5@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=horst.reiterer@gmail.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®