From: Markus Elfring <Markus.Elfring@web.de>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, lkp@intel.com,
Dan Carpenter <dan.carpenter@oracle.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v4 4/4] Input: adp5589: Fix possible memory leak of 'kpad'
Date: Tue, 7 Apr 2020 15:40:07 +0200 [thread overview]
Message-ID: <5250434e-d83a-908e-ec7e-c84212e67e85@web.de> (raw)
> If 'adp5589_i2c_get_driver_data()' returns an error, the exit path should
> be to also free the 'kpad' object.
Wording alternative:
Release the kpad object also after a failed call of
the function “adp5589_i2c_get_driver_data”.
> This change fixes that.
Please replace this sentence by the tag “Fixes”
(because the exception handling was improved).
Regards,
Markus
reply other threads:[~2020-04-07 13:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5250434e-d83a-908e-ec7e-c84212e67e85@web.de \
--to=markus.elfring@web.de \
--cc=alexandru.ardelean@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®