From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: bdas@redhat.com, dmatlack@google.com
Subject: Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation
Date: Thu, 9 Mar 2017 11:50:56 +0100 [thread overview]
Message-ID: <52507881-6444-8704-7c3a-a9c87f8e0a9b@redhat.com> (raw)
In-Reply-To: <5de81ced-c083-25e1-8954-6c232b9a7acd@redhat.com>
Am 09.03.2017 um 11:43 schrieb David Hildenbrand:
> Am 08.03.2017 um 19:03 schrieb Paolo Bonzini:
>> handle_ept_violation is checking for "guest-linear-address invalid" +
>> "paging-structure walk", which is a sign of a bug in KVM. However,
>> _all_ EPT violations without a valid guest linear address are paging
>> structure walks, because those EPT violations happen when loading the
>> guest PDPTEs. So simplify the check to only look at bit 7 of the
>> exit qualification.
>
> Do we have any define for this magic bit 7?
>
> #EPT_EXITQ_GLA_VALID 0x80
>
Introducing
#define EPT_VIOLATION_GLA_VALID_BIT
#define EPT_VIOLATION_GLA_VALID
would make sense.
--
Thanks,
David
next prev parent reply other threads:[~2017-03-09 10:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 18:03 [PATCH 0/6] KVM: nVMX: nested EPT improvements and A/D bits, RDRAND and RDSEED exits Paolo Bonzini
2017-03-08 18:03 ` [PATCH 1/6] KVM: nVMX: we support 1GB EPT pages Paolo Bonzini
2017-03-09 10:34 ` David Hildenbrand
2017-03-08 18:03 ` [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation Paolo Bonzini
2017-03-09 10:43 ` David Hildenbrand
2017-03-09 10:50 ` David Hildenbrand [this message]
2017-03-28 10:09 ` Paolo Bonzini
2017-03-08 18:03 ` [PATCH 3/6] kvm: x86: MMU support for EPT accessed/dirty bits Paolo Bonzini
2017-03-08 18:03 ` [PATCH 4/6] kvm: nVMX: support " Paolo Bonzini
2017-03-08 18:03 ` [PATCH 5/6] KVM: VMX: add missing exit reasons Paolo Bonzini
2017-03-09 9:27 ` David Hildenbrand
2017-03-08 18:03 ` [PATCH 6/6] KVM: nVMX: support RDRAND and RDSEED exiting Paolo Bonzini
2017-03-13 18:27 ` Jim Mattson
2017-03-14 9:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52507881-6444-8704-7c3a-a9c87f8e0a9b@redhat.com \
--to=david@redhat.com \
--cc=bdas@redhat.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®