From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Jiri Kosina <trivial@kernel.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omapfb/dss: remove unneeded conversions to bool
Date: Fri, 3 Jan 2020 13:40:27 +0100 [thread overview]
Message-ID: <5251890d-e12e-c78c-9790-fe8764501744@samsung.com> (raw)
In-Reply-To: <20191016180424.23907-1-afd@ti.com>
On 10/16/19 8:04 PM, Andrew F. Davis wrote:
> Found with scripts/coccinelle/misc/boolconv.cocci.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
> index 376ee5bc3ddc..ce37da85cc45 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
> @@ -1635,7 +1635,7 @@ static void dispc_ovl_set_scaling_uv(enum omap_plane plane,
> {
> int scale_x = out_width != orig_width;
> int scale_y = out_height != orig_height;
> - bool chroma_upscale = plane != OMAP_DSS_WB ? true : false;
> + bool chroma_upscale = plane != OMAP_DSS_WB;
>
> if (!dss_has_feature(FEAT_HANDLE_UV_SEPARATE))
> return;
> @@ -3100,9 +3100,9 @@ static bool _dispc_mgr_pclk_ok(enum omap_channel channel,
> unsigned long pclk)
> {
> if (dss_mgr_is_lcd(channel))
> - return pclk <= dispc.feat->max_lcd_pclk ? true : false;
> + return pclk <= dispc.feat->max_lcd_pclk;
> else
> - return pclk <= dispc.feat->max_tv_pclk ? true : false;
> + return pclk <= dispc.feat->max_tv_pclk;
> }
>
> bool dispc_mgr_timings_ok(enum omap_channel channel,
prev parent reply other threads:[~2020-01-03 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191016180541epcas5p4d85d004250e99c95c876da3c03d4d46e@epcas5p4.samsung.com>
2019-10-16 18:04 ` Andrew F. Davis
2020-01-03 12:40 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5251890d-e12e-c78c-9790-fe8764501744@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=afd@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®