From: Jacob Keller <jacob.e.keller@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>, <Yeking@Red54.com>
Cc: <kuba@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Theodore Ts'o <tytso@mit.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Andy Whitcroft" <apw@canonical.com>,
Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
<workflows@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<tech-board-discuss@lists.linux.dev>
Subject: Re: [PATCH] Add short author date to Fixes tag
Date: Fri, 10 Jan 2025 16:21:35 -0800 [thread overview]
Message-ID: <52541f79-ba1c-49c9-a576-45c3472d1c79@intel.com> (raw)
In-Reply-To: <20250110080331.04645768@gandalf.local.home>
On 1/10/2025 5:03 AM, Steven Rostedt wrote:
> On Fri, 10 Jan 2025 12:20:09 +0000
> Yeking@Red54.com wrote:
>
>> The old Fixes tag style is at least 10 years old. It lacks date
>> information, which can lead to misjudgment. So I added short author date
>> to avoid this. This make it clear at a glance and reduce
>> misunderstandings.
>
> How can it lead to misjudgment? If you have two or more hashes matching, do
> you really think they'll have the same subjects?
>
> I do not plan on doing this. It's pointless.
>
> -- Steve
While the addition of the date is a widely used variant within the git
community, this was rejected by the kernel community in the past as
well. I remember posting fixes tags with the date several years ago and
getting push back.
I tried to find reference to these discussions but I can't seem to
locate them anymore on the archives.
I personally find the date helpful as it can help place a commit without
needing to take the extra time to do a lookup.
However, all of the existing tooling we have for the kernel does not
support the date, and I think its not worth trying to change it at this
point. It doesn't make sense to break all this tooling for information
which is accessible in other forms. Indeed, as long as the hash is
sufficiently long, the change of a collision is minimal.
next prev parent reply other threads:[~2025-01-11 0:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:12 [PATCH] net: ethernet: sunplus: Switch to ndo_eth_ioctl Yeking
2025-01-08 18:09 ` Jakub Kicinski
2025-01-09 2:05 ` [net PATCH v2] " Yeking
2025-01-09 14:03 ` Andrew Lunn
2025-01-10 2:02 ` Jakub Kicinski
2025-01-10 11:53 ` [PATCH net v3] " Yeking
2025-01-10 12:20 ` [PATCH] Add short author date to Fixes tag Yeking
2025-01-10 12:32 ` Greg Kroah-Hartman
2025-01-10 13:03 ` Steven Rostedt
2025-01-11 0:21 ` Jacob Keller [this message]
2025-01-11 5:48 ` Greg Kroah-Hartman
2025-01-11 17:09 ` Steven Rostedt
2025-01-12 10:54 ` Geert Uytterhoeven
2025-01-13 14:51 ` Steven Rostedt
2025-01-13 15:08 ` Mark Brown
2026-02-25 0:56 Alejandro Colomar
2026-02-25 0:57 ` Alejandro Colomar
2026-02-25 18:00 ` Greg Kroah-Hartman
2026-02-25 18:20 ` Alejandro Colomar
2026-02-25 19:47 ` James Bottomley
2026-02-25 21:23 ` Greg Kroah-Hartman
2026-02-25 21:45 ` Alejandro Colomar
2026-02-25 22:35 ` Theodore Tso
2026-02-25 23:27 ` Sasha Levin
2026-02-25 23:46 ` Greg Kroah-Hartman
2026-02-26 0:20 ` Alejandro Colomar
2026-02-26 7:50 ` Geert Uytterhoeven
2026-02-25 20:08 ` Sasha Levin
2026-02-26 0:08 ` Steven Rostedt
2026-02-26 23:24 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52541f79-ba1c-49c9-a576-45c3472d1c79@intel.com \
--to=jacob.e.keller@intel.com \
--cc=Yeking@Red54.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tech-board-discuss@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®