From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130Ab3JJMJA (ORCPT ); Thu, 10 Oct 2013 08:09:00 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:35822 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343Ab3JJMI5 (ORCPT ); Thu, 10 Oct 2013 08:08:57 -0400 Message-ID: <525698BC.3080902@ti.com> Date: Thu, 10 Oct 2013 17:38:28 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Mark Rutland CC: "rob.herring@calxeda.com" , Pawel Moll , "swarren@wwwdotorg.org" , "cw00.choi@samsung.com" , "ijc+devicetree@hellion.org.uk" , "rob@landley.net" , "myungjoo.ham@samsung.com" , "ldewangan@nvidia.com" , "gg@slimlogic.co.uk" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* References: <1381390377-11109-1-git-send-email-kishon@ti.com> <20131010093908.GD26954@e106331-lin.cambridge.arm.com> In-Reply-To: <20131010093908.GD26954@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 10 October 2013 03:09 PM, Mark Rutland wrote: > On Thu, Oct 10, 2013 at 08:32:57AM +0100, Kishon Vijay Abraham I wrote: >> The Palmas device contains only a USB VBUS-ID detector, so added a >> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible >> types for backward compatibility. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Changes from v4: >> * added compatible property "ti,twl6035-usb-vid" >> >> Changes from v3: >> * Fixed commit log message (VID to VBUS-ID). >> * Fixed the Documentation to tell "ti,twl6035-usb" and "ti,palmas-usb" is >> deprecated >> Changes from [1]: >> * Since the old compatible values will be in 3.11 kernel, we shouldn't remove >> the old compatible values. So retain the old compatible values. >> >> [1] -> http://www.spinics.net/lists/linux-omap/msg95843.html >> >> Documentation/devicetree/bindings/extcon/extcon-palmas.txt | 4 +++- >> drivers/extcon/extcon-palmas.c | 2 ++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt >> index 7dab6a8..ce2100f 100644 >> --- a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt >> +++ b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt >> @@ -2,7 +2,9 @@ EXTCON FOR PALMAS/TWL CHIPS >> >> PALMAS USB COMPARATOR >> Required Properties: >> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb" >> + - compatible : Should be "ti,palmas-usb-vid" or "ti,twl6035-usb-vid". >> + "ti,twl6035-usb" and "ti,palmas-usb" is deprecated and is kept >> + for backward compatibility. > > How about having these one per line, with a description: > > - compatible: should contain one of: > * "ti,palmas-usb-vid" for palmas systems. > * "ti,twl6035-usb-vid" for twl6035 systems. twl6035 is just an another name for palmas. Thanks Kishon