From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
To: John Fastabend <john.fastabend@gmail.com>,
Dave Taht <dave.taht@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Martin Elshuber <martin.elshuber@theobroma-systems.com>
Subject: Re: [bug, bisected] pfifo_fast causes packet reordering
Date: Wed, 14 Mar 2018 11:09:02 +0100 [thread overview]
Message-ID: <52581141-db46-8657-e0b5-161e236caa1b@theobroma-systems.com> (raw)
In-Reply-To: <95844480-d020-9000-53ef-0da8b965ce6e@gmail.com>
On 14.03.18 05:03, John Fastabend wrote:
>>> During stress-testing our "ucan" USB/CAN adapter SocketCAN driver on Linux
>>> v4.16-rc4-383-ged58d66f60b3 we observed that a small fraction of packets are
>>> delivered out-of-order.
>>>
>
> Is the stress-testing tool available somewhere? What type of packets
> are being sent?
Not public, no, the problem is that you'd need a CAN adapter as well.
The test is simple, sending CAN frames with an increasing counter and a
random length payload:
[ tx thread rx thread ]
| ^
v |
[ interface 0 ] ---- cable ----> [ interface 1 ]
I'll see if I can come up with a UDP testcase that works with normal
ethernet interfaces.
> Is this a single queue device or a multiqueue device? Running
> 'tc -s qdisc show dev foo' would help some.
Here you go:
root@rk3399-q7:~# tc -s qdisc show dev can0
qdisc pfifo_fast 0: root refcnt 2 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1
1 1 1 1 1
Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
backlog 0b 0p requeues 0
> If we introduced a OOO edge case somewhere that was not
> intended so I'll take a look into it. But, if you can provide
> a bit more details on how stress testing is done to cause the
> issue that would help.
Will do.
Thanks,
Jakob
next prev parent reply other threads:[~2018-03-14 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 18:24 Jakob Unterwurzacher
2018-03-13 18:35 ` Dave Taht
2018-03-14 4:03 ` John Fastabend
2018-03-14 10:09 ` Jakob Unterwurzacher [this message]
2018-03-15 18:08 ` Jakob Unterwurzacher
2018-03-15 22:30 ` John Fastabend
2018-03-16 10:26 ` Jakob Unterwurzacher
2018-03-19 6:07 ` Alexander Stein
2018-03-19 12:32 ` Paolo Abeni
2018-03-19 12:56 ` Jakob Unterwurzacher
2018-03-21 10:01 ` Jakob Unterwurzacher
2018-03-21 18:43 ` John Fastabend
2018-03-21 19:44 ` Jakob Unterwurzacher
2018-03-21 20:52 ` John Fastabend
2018-03-22 10:16 ` Jakob Unterwurzacher
2018-03-24 14:26 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52581141-db46-8657-e0b5-161e236caa1b@theobroma-systems.com \
--to=jakob.unterwurzacher@theobroma-systems.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.elshuber@theobroma-systems.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®